-
Notifications
You must be signed in to change notification settings - Fork 201
fix(meter): update layout tokens #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0aadc8a
to
d384150
Compare
🚀 Deployed on https://pr-2080--spectrum-css.netlify.app |
1f64680
to
c2a827b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments/questions!
...globals, | ||
size: `${size}`, | ||
label: `${label}`, | ||
alignment: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just remove this if you don't have anything to pass through
0205597
to
12a3a2d
Compare
Description
Updates Meter to use new layout tokens:
meter-minimum-width
meter-maximum-width
meter-default-width
meter-thickness-small
meter-thickness-large
Large value from
component-top-to-text-200
tocomponent-top-to-text-75
Add
Meter
StoriesAdded controls to Progress Bar: value and label
Bit of context, for now
Meter
usesProgressBar
css.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Test Outline
Regression testing
Validate:
Screenshots
Before
After
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨