Skip to content

fix(meter): update layout tokens #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Aug 10, 2023

Description

  1. Updates Meter to use new layout tokens:
    meter-minimum-width
    meter-maximum-width
    meter-default-width
    meter-thickness-small
    meter-thickness-large
    Large value from component-top-to-text-200 to component-top-to-text-75 

  2. Add Meter Stories

  3. Added controls to Progress Bar: value and label

Bit of context, for now Meter uses ProgressBar css.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Test Outline

  1. Open the storybook for the Meter component:
  • Ensure Meter displays appropriately
  • Toggle between fill colors
  • toggle between meter sizing [@mlogsdon18]
  1. Open the storybook for the Progress Bar component:
  • Ensure controls all work as they should [@mlogsdon18]
  1. Open the Docs site for the Meter component.
  • inspect for new tokens

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

Before

Screenshot 2023-08-10 at 4 08 49 PM

After

Screenshot 2023-08-10 at 4 09 18 PM

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz force-pushed the jenndiaz/css-477-meter-layout-tokens branch from 0aadc8a to d384150 Compare August 10, 2023 16:05
@jenndiaz jenndiaz changed the title Jenndiaz/css 477 meter layout tokens fix(meter): update layout tokens Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

🚀 Deployed on https://pr-2080--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 16:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 19:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 21:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 16:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 16:41 Inactive
@jenndiaz jenndiaz force-pushed the jenndiaz/css-477-meter-layout-tokens branch from 1f64680 to c2a827b Compare August 11, 2023 16:43
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 16:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 21:17 Inactive
@jenndiaz jenndiaz marked this pull request as ready for review August 11, 2023 21:17
@jenndiaz jenndiaz requested review from mlogsdon18 and jawinn August 14, 2023 16:08
Copy link
Contributor

@mlogsdon18 mlogsdon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments/questions!

...globals,
size: `${size}`,
label: `${label}`,
alignment: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove this if you don't have anything to pass through

@github-actions github-actions bot temporarily deployed to pull request August 14, 2023 22:01 Inactive
@jenndiaz jenndiaz requested a review from castastrophe August 15, 2023 15:06
@jenndiaz jenndiaz requested a review from pfulton August 23, 2023 16:15
@jenndiaz jenndiaz force-pushed the jenndiaz/css-477-meter-layout-tokens branch from 0205597 to 12a3a2d Compare August 24, 2023 21:39
@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 21:51 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Aug 25, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Aug 25, 2023
@pfulton pfulton merged commit da88b3c into main Aug 25, 2023
@pfulton pfulton deleted the jenndiaz/css-477-meter-layout-tokens branch August 25, 2023 13:43
@github-actions github-actions bot mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants