[REVIEW ONLY] Split View Refactoring #8045
Conversation
| * Removes a list of files from the working set | ||
| * @param {Array.<File>=} list Pass this arg to search a different array of files. Internal | ||
| * use only. | ||
| * @param {boolean=} true to close the current document too [deprecated] |
There was a problem hiding this comment.
No need to mark @param deprecated if entire function is deprecated.
There was a problem hiding this comment.
the param is not supported in the new function so it's worth mentioning IMO
|
Done with initial review pass. |
| // Call clear current document here because we need the editor | ||
| // to close the current document and this is the only way to | ||
| // do that at the moment. | ||
| DocumentManager.clearCurrentDocument(); |
There was a problem hiding this comment.
Why do you need to call DocumentManager.clearCurrentDocument() here? Is this because of a change with this PR, or does it fix a bug that existed before?
There was a problem hiding this comment.
Because DocumentManger.removeLIstFromWorkingSet() is deprecated and the replacement does not support the clearCurrentDocument discreet -- it was already an exported API but private so I just removed the private part and call it from here to close the document. This will get refactored again.
This is the refactoring effort to move Working Set API's and start deprecating some of the DocumentManager APIs
This probably isn't ready for prime time consumption but want to get any feedback on the approach and if there is anything I forgot.
Also I encourage as much test exposure as possible to make sure nothing is broken.