Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[REVIEW ONLY] Split View Refactoring #8045

Closed
wants to merge 78 commits into from
Closed
Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
4dadcb3
Merge branch 'master' of https://github.com/adobe/brackets
JeffryBooher Apr 5, 2014
e99c6ee
initial checkin
JeffryBooher May 15, 2014
3d0092e
rename panel manager
JeffryBooher May 16, 2014
ede4942
WorkingSetView => PaneListView
JeffryBooher May 19, 2014
beec3fa
workingsetsort -> panelistsort, panelistview -> panelistview
JeffryBooher May 20, 2014
d17d923
resolve conflicts
JeffryBooher May 20, 2014
61bef43
refactor sort command handler
JeffryBooher May 21, 2014
51c0894
rename automaticSort
JeffryBooher May 21, 2014
3cda537
workingSet -> paneList renames
JeffryBooher May 21, 2014
3628f6f
rename FILE.ADD_TO_WORKINGSET
JeffryBooher May 21, 2014
243f1de
rename working set command
JeffryBooher May 21, 2014
3749812
SORT_WORKINGSET_AUTO => SORT_PANEWLIST_AUTO
JeffryBooher May 21, 2014
703b9b1
cleanup/deprecate workingSetSort commands
JeffryBooher May 22, 2014
cf2e104
update strings
JeffryBooher May 22, 2014
4e52024
formatting
JeffryBooher May 22, 2014
2bbf790
rename working set menus
JeffryBooher May 22, 2014
9420ecd
string change
JeffryBooher May 22, 2014
de1d7f7
start moving working set apis
JeffryBooher May 22, 2014
c88d71f
first api successfully migrated
JeffryBooher May 23, 2014
129ec66
fix reset and a few other things. All tests passing
JeffryBooher May 23, 2014
52c0dd4
deprecate events
JeffryBooher May 23, 2014
e30121a
paneview -> paneListView
JeffryBooher May 23, 2014
df70d5e
cleanup and doc
JeffryBooher May 24, 2014
4787f80
move removeApis, fix a few issues
JeffryBooher May 24, 2014
919314d
move more removeApis, fix issues
JeffryBooher May 24, 2014
863eba4
move workingsetsort
JeffryBooher May 24, 2014
5abf892
paneListView drag&drop, sort events
JeffryBooher May 24, 2014
33d5ed6
paneListView traversing
JeffryBooher May 24, 2014
0714cf6
refactor notifyPathDeleted
JeffryBooher May 24, 2014
8269392
panelist serialization
JeffryBooher May 24, 2014
fad6511
move editor events into MainViewManager
JeffryBooher May 24, 2014
1082ee7
first change successful
JeffryBooher May 27, 2014
3e54f88
wip:working
JeffryBooher May 27, 2014
3a4b246
wip:more working
JeffryBooher May 27, 2014
3f0d5cc
cleanup
JeffryBooher May 27, 2014
302937e
final fixes and cleanup
JeffryBooher May 27, 2014
c257052
on more final cleanup
JeffryBooher May 27, 2014
dec81ef
Merge pull request #7942 from adobe/jeff/splitview-cd2
JeffryBooher May 27, 2014
503c03a
merge with master
JeffryBooher May 27, 2014
f781944
merge with master
JeffryBooher May 27, 2014
d268ce6
fix autosort on startup
JeffryBooher May 27, 2014
21ca74c
deprecating WorkingSetView and PanelManager in favor of new MainViewM…
bchintx May 30, 2014
fcf1996
next pass at deprecating API calls
bchintx May 30, 2014
66cd45b
deprecating a few more API calls based on a Find in Files search
bchintx May 30, 2014
65cf5f5
removing extra require statement
bchintx May 30, 2014
f64eada
merge with master
JeffryBooher Jun 2, 2014
0a1c18c
deprecate PanelManager.createBottomPanel
JeffryBooher Jun 2, 2014
cc908aa
fix lint and warn once
JeffryBooher Jun 2, 2014
36308f8
fix test failures
JeffryBooher Jun 2, 2014
4e980bd
fix close others test failure
JeffryBooher Jun 2, 2014
eb9cb9d
fix deprecation warning
JeffryBooher Jun 2, 2014
cd5464d
migrate sort pref / fix type sort
JeffryBooher Jun 3, 2014
d4674a6
update test
JeffryBooher Jun 3, 2014
f7f3e59
update test
JeffryBooher Jun 3, 2014
fae4177
Remove scaffolding stubs and Deprecated APIs that aren't used accordi…
JeffryBooher Jun 3, 2014
f04df19
re-add removeListFromWorkingSet used by newly added vim extension
JeffryBooher Jun 3, 2014
681a027
fix broken menus and panels for extensions
JeffryBooher Jun 4, 2014
f810efc
lint
JeffryBooher Jun 4, 2014
e9a483f
adding PaneViewListSort unit tests
bchintx Jun 4, 2014
d44ad46
cleanup
JeffryBooher Jun 4, 2014
32fe3f4
Merge branch 'jeff/splitview-merge' of https://github.com/adobe/brack…
JeffryBooher Jun 4, 2014
31cce39
solve legacy event order dependency for eextensions
JeffryBooher Jun 4, 2014
adfa5f5
fixes and changes from self review
JeffryBooher Jun 5, 2014
2ec8d36
merge with master
JeffryBooher Jun 5, 2014
d6c9036
roll language changes back
JeffryBooher Jun 5, 2014
11c54ea
formatting
JeffryBooher Jun 5, 2014
dc3a2f8
add 'EXTENSIONS_READY appInit so deprecated events can be registered,…
JeffryBooher Jun 5, 2014
6c32741
update docs
JeffryBooher Jun 5, 2014
f792ef9
RTC:Fix some jsDoc stuff
JeffryBooher Jun 5, 2014
9e68817
fixes lint
JeffryBooher Jun 5, 2014
751684d
fix command handler
JeffryBooher Jun 9, 2014
b56e852
respond to comments
JeffryBooher Jun 10, 2014
6b338d0
more JSDoc fixes
JeffryBooher Jun 10, 2014
f65f1f5
more JSDoc fixes
JeffryBooher Jun 10, 2014
1f9cae7
update jsdoc
JeffryBooher Jun 10, 2014
62032a2
update
JeffryBooher Jun 10, 2014
0157d11
unit test upgrades
JeffryBooher Jun 11, 2014
bff8717
one more test for close others extension
JeffryBooher Jun 11, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/LiveDevelopment/LiveDevelopment.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ define(function LiveDevelopment(require, exports, module) {
FileSystemError = require("filesystem/FileSystemError"),
FileUtils = require("file/FileUtils"),
LiveDevServerManager = require("LiveDevelopment/LiveDevServerManager"),
MainViewManager = require("view/MainViewManager"),
NativeApp = require("utils/NativeApp"),
PreferencesDialogs = require("preferences/PreferencesDialogs"),
ProjectManager = require("project/ProjectManager"),
Expand Down Expand Up @@ -1261,8 +1262,8 @@ define(function LiveDevelopment(require, exports, module) {
otherDocumentsInWorkingFiles;

if (doc && !doc._masterEditor) {
otherDocumentsInWorkingFiles = DocumentManager.getWorkingSet().length;
DocumentManager.addToWorkingSet(doc.file);
otherDocumentsInWorkingFiles = MainViewManager.getPaneViewList(MainViewManager.FOCUSED_PANE).length;
MainViewManager.addToPaneViewList(MainViewManager.FOCUSED_PANE, doc.file);

if (!otherDocumentsInWorkingFiles) {
DocumentManager.setCurrentDocument(doc);
Expand Down
18 changes: 13 additions & 5 deletions src/brackets.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ define(function (require, exports, module) {
EditorManager = require("editor/EditorManager"),
CSSInlineEditor = require("editor/CSSInlineEditor"),
JSUtils = require("language/JSUtils"),
WorkingSetView = require("project/WorkingSetView"),
WorkingSetSort = require("project/WorkingSetSort"),
PaneViewListView = require("project/PaneViewListView"),
PaneViewListSort = require("project/PaneViewListSort"),
DocumentCommandHandlers = require("document/DocumentCommandHandlers"),
FileViewController = require("project/FileViewController"),
FileSyncManager = require("project/FileSyncManager"),
Expand Down Expand Up @@ -103,6 +103,7 @@ define(function (require, exports, module) {
NativeApp = require("utils/NativeApp"),
DeprecationWarning = require("utils/DeprecationWarning"),
ViewCommandHandlers = require("view/ViewCommandHandlers"),
MainViewManager = require("view/MainViewManager"),
_ = require("thirdparty/lodash");

// DEPRECATED: In future we want to remove the global CodeMirror, but for now we
Expand All @@ -116,7 +117,7 @@ define(function (require, exports, module) {
return CodeMirror;
}
});

// Load modules that self-register and just need to get included in the main project
require("command/DefaultMenus");
require("document/ChangedDocumentTracker");
Expand All @@ -137,6 +138,9 @@ define(function (require, exports, module) {
require("file/NativeFileSystem");
require("file/NativeFileError");

// Compatibility shim for PanelManager to WorkspaceManager migration
require("view/PanelManager");

PerfUtils.addMeasurement("brackets module dependencies resolved");

// Local variables
Expand Down Expand Up @@ -182,6 +186,7 @@ define(function (require, exports, module) {
LanguageManager : LanguageManager,
LiveDevelopment : require("LiveDevelopment/LiveDevelopment"),
LiveDevServerManager : require("LiveDevelopment/LiveDevServerManager"),
MainViewManager : MainViewManager,
Menus : Menus,
MultiRangeInlineEditor : require("editor/MultiRangeInlineEditor").MultiRangeInlineEditor,
NativeApp : NativeApp,
Expand All @@ -191,7 +196,7 @@ define(function (require, exports, module) {
RemoteAgent : require("LiveDevelopment/Agents/RemoteAgent"),
ScrollTrackMarkers : require("search/ScrollTrackMarkers"),
UpdateNotification : require("utils/UpdateNotification"),
WorkingSetView : WorkingSetView,
PaneViewListView : PaneViewListView,

doneLoading : false
};
Expand Down Expand Up @@ -242,6 +247,9 @@ define(function (require, exports, module) {

// Load the initial project after extensions have loaded
extensionLoaderPromise.always(function () {
// Signal that extensions are loaded
AppInit._dispatchReady(AppInit.EXTENSIONS_READY);

// Finish UI initialization
ViewCommandHandlers.restoreFontSize();
var initialProjectPath = ProjectManager.getInitialProjectPath();
Expand All @@ -259,7 +267,7 @@ define(function (require, exports, module) {
if (ProjectManager.isWelcomeProjectPath(initialProjectPath)) {
FileSystem.resolve(initialProjectPath + "index.html", function (err, file) {
if (!err) {
var promise = CommandManager.execute(Commands.FILE_ADD_TO_WORKING_SET, { fullPath: file.fullPath });
var promise = CommandManager.execute(Commands.CMD_ADD_TO_PANE_VIEW_LIST, { fullPath: file.fullPath });
promise.then(deferred.resolve, deferred.reject);
} else {
deferred.reject();
Expand Down
Loading