This repository was archived by the owner on Sep 6, 2021. It is now read-only.
SplitView Refactoring #8105
Closed
SplitView Refactoring #8105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
src/view/MainViewManager.js
Outdated
src/utils/DeprecationWarning.js
Outdated
Contributor
There was a problem hiding this comment.
"cannonical" seems a bit formal here. What about replacing it with "display"?
Otherwise, it's misspelled -- should be "canonical".
Contributor
|
Done with review. |
src/project/PaneViewListView.js
Outdated
Contributor
There was a problem hiding this comment.
The index needs to be changed at some point. Maybe on the next line. If it is not changed and you keep dragging it will cause an issue on the next swap.
Same with the other swap.
Contributor
Author
|
closing this pull request. Next iteration will be in jeff/splitview-1x2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #8045
This is the refactoring effort to move Working Set API's and start deprecating some of the DocumentManager APIs
This probably isn't ready for prime time consumption but want to get any feedback on the approach and if there is anything I forgot.
Also I encourage as much test exposure as possible to make sure nothing is broken.