-
Notifications
You must be signed in to change notification settings - Fork 606
Support cmd-a, c, v, x for text input in native dialogs like file open, save #481
Conversation
|
Awesome! Fixes adobe/brackets#4561. |
|
@anirudhsasikumar Nice work! I did try it and discover that we also need to implement for undo and redo in these input field. Can you add Cmd-Z and Cmd-Shift-Z in your implementation? |
|
@anirudhsasikumar I think this implementation is causing an undesirable side effect; when pasting something in the editor window, we're getting the double pasting of the clipboard. |
|
@RaymondLim Ah - then the check: Needs to be applied not just for select all, but for copy/cut/paste as well. I'm guessing code mirror is handling paste by itself (without the actual paste command firing). |
|
I will double check and update this pull. |
|
@RaymondLim Please take a look now, the selectors will only fire when CEF isn't in focus. |
appshell/cefclient_mac.mm
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to have Cmd-Y for redo, but most mac apps provide Cmd-Shift-Z as redo. So we also need to handle that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed - only using Command-Shift-Z for redo now.
|
Looks good! Merging now. |
Support cmd-a, c, v, x for text input in native dialogs like file open, save
Support cmd-a, c, v, x for text input in native dialogs like file open, save
Addresses this bug:
Actual: Try Cmd-A, C, X, V - they do not work.
Expected: They work.