Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Conversation

@anirudhsasikumar
Copy link
Contributor

Addresses this bug:

  1. File -> Open.
  2. Type in some text in the file open dialog (in the search field in Yosemite or filename text input)

Actual: Try Cmd-A, C, X, V - they do not work.
Expected: They work.

@peterflynn
Copy link
Member

Awesome! Fixes adobe/brackets#4561.

@RaymondLim
Copy link
Contributor

@anirudhsasikumar Nice work! I did try it and discover that we also need to implement for undo and redo in these input field. Can you add Cmd-Z and Cmd-Shift-Z in your implementation?

@RaymondLim
Copy link
Contributor

@anirudhsasikumar I think this implementation is causing an undesirable side effect; when pasting something in the editor window, we're getting the double pasting of the clipboard.

@anirudhsasikumar
Copy link
Contributor Author

@RaymondLim Ah - then the check:

if ([[self mainWindow] firstResponder] == [self mainWindow]) {

Needs to be applied not just for select all, but for copy/cut/paste as well. I'm guessing code mirror is handling paste by itself (without the actual paste command firing).

@anirudhsasikumar
Copy link
Contributor Author

I will double check and update this pull.

@anirudhsasikumar
Copy link
Contributor Author

@RaymondLim Please take a look now, the selectors will only fire when CEF isn't in focus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to have Cmd-Y for redo, but most mac apps provide Cmd-Shift-Z as redo. So we also need to handle that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - only using Command-Shift-Z for redo now.

@RaymondLim
Copy link
Contributor

Looks good! Merging now.

RaymondLim added a commit that referenced this pull request Nov 10, 2014
Support cmd-a, c, v, x for text input in native dialogs like file open, save
@RaymondLim RaymondLim merged commit 6cbe86f into adobe:master Nov 10, 2014
RaymondLim added a commit that referenced this pull request Dec 8, 2015
Support cmd-a, c, v, x for text input in native dialogs like file open, save
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants