[CLOSED] Support cmd-a, c, v, x for text input in native dialogs like file open, save

[core-ai-bot]

Issue by anirudhsasikumar
Thursday Oct 23, 2014 at 22:41 GMT
Originally opened as adobe#481

---

Addresses this bug:

1. File -> Open.
2. Type in some text in the file open dialog (in the search field in Yosemite or filename text input)

Actual: Try Cmd-A, C, X, V - they do not work.
Expected: They work.

---

anirudhsasikumar included the following code: https://github.com/adobe/brackets-shell/pull/481/commits

[core-ai-bot]

Comment by peterflynn
Thursday Oct 23, 2014 at 23:30 GMT

---

Awesome! Fixes adobe/brackets#4561.

[core-ai-bot]

Comment by RaymondLim
Monday Nov 10, 2014 at 18:31 GMT

---

@anirudhsasikumar Nice work! I did try it and discover that we also need to implement for undo and redo in these input field. Can you add Cmd-Z and Cmd-Shift-Z in your implementation?

[core-ai-bot]

Comment by RaymondLim
Monday Nov 10, 2014 at 18:43 GMT

---

@anirudhsasikumar I think this implementation is causing an undesirable side effect; when pasting something in the editor window, we're getting the double pasting of the clipboard.

[core-ai-bot]

Comment by anirudhsasikumar
Monday Nov 10, 2014 at 20:42 GMT

---

@RaymondLim Ah - then the check:

if ([[self mainWindow] firstResponder] == [self mainWindow]) {

Needs to be applied not just for select all, but for copy/cut/paste as well. I'm guessing code mirror is handling paste by itself (without the actual paste command firing).

[core-ai-bot]

Comment by anirudhsasikumar
Monday Nov 10, 2014 at 20:46 GMT

---

I will double check and update this pull.

[core-ai-bot]

Comment by anirudhsasikumar
Monday Nov 10, 2014 at 20:58 GMT

---

@RaymondLim Please take a look now, the selectors will only fire when CEF isn't in focus.

[core-ai-bot]

Comment by RaymondLim
Monday Nov 10, 2014 at 21:16 GMT

---

Looks good! Merging now.