Skip to content

New: migration.js added to grunt tasks (fixes #3632) #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-allen-89 merged 13 commits into from
Mar 17, 2025
Merged

New: migration.js added to grunt tasks (fixes #3632) #3633

joe-allen-89 merged 13 commits into from
Mar 17, 2025

Conversation

@joe-allen-89
Copy link
Contributor

@joe-allen-89 joe-allen-89 commented Jan 7, 2025

#3632

New

@joe-allen-89 joe-allen-89 self-assigned this Jan 7, 2025
@joe-allen-89 joe-allen-89 linked an issue Jan 7, 2025 that may be closed by this pull request
Add migration grunt file to framework #3632
Closed
oliverfoster
oliverfoster reviewed Jan 7, 2025
View reviewed changes
This was referenced Jan 15, 2025
Merged
Merged
Merged
oliverfoster
oliverfoster reviewed Jan 23, 2025
View reviewed changes
oliverfoster
oliverfoster reviewed Jan 23, 2025
View reviewed changes
swashbuck
swashbuck approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

oliverfoster
oliverfoster requested changes Jan 27, 2025
View reviewed changes
@oliverfoster
Copy link
Member

oliverfoster commented Jan 27, 2025 •
edited
Loading

It's not a devdependency, because it's not used by the developers of the adapt-framework, like the linting. It's a dependency because it's used by the users of the adapt-framework to fulfill a use-case of the framework.

@joe-allen-89
Copy link
Contributor Author

joe-allen-89 commented Jan 27, 2025

It's not a devdependency, because it's not used be the developers of the adapt-framework, like the linting. It's a dependency because it's used by the users of the adapt-framework to fulfill a use-case of the framework.

I interpretated it as devdependency as it's used by devs for plugin development (when migration is needed), but it is end user using it so will move to dependency.

@joe-replin joe-replin mentioned this pull request Jan 30, 2025
Merged
This was referenced Feb 10, 2025
Merged
Merged
@oliverfoster oliverfoster mentioned this pull request Feb 25, 2025
Merged
@joe-allen-89 joe-allen-89 merged commit 630e6ab into master Mar 17, 2025
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/3632 branch March 17, 2025 13:23
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 17, 2025
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@semantic-release-bot
Chore(release): 5.43.0 [skip ci]
e787357 
# [5.43.0](v5.42.7...v5.43.0) (2025-03-17)

### New

* migration.js added to grunt tasks (fixes #3632) (#3633) ([630e6ab](630e6ab)), closes [#3632](#3632) [#3633](#3633) [#3632](#3632) [#3632](#3632) [#3644](#3644) [#3645](#3645)
@github-actions
Copy link

github-actions bot commented Mar 17, 2025

🎉 This PR is included in version 5.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool Awaiting requested review from cahirodoherty-learningpool

Assignees

@joe-allen-89 joe-allen-89

Labels

enhancement Ready to release released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add migration grunt file to framework

4 participants

@joe-allen-89 @oliverfoster @swashbuck