Skip to content

Fix: Reenable testing #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 1 commit into from
Jan 22, 2025
Merged

Fix: Reenable testing #3644

oliverfoster merged 1 commit into from
Jan 22, 2025
+5 −9

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 22, 2025

Fix

  • Pass the logger through the the test command

@oliverfoster oliverfoster self-assigned this Jan 22, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 8ca9917 into issue/3632 Jan 22, 2025
2 checks passed
@oliverfoster oliverfoster deleted the issue/3632b branch January 22, 2025 10:52
joe-allen-89 added a commit that referenced this pull request Mar 17, 2025
@joe-allen-89 @oliverfoster
New: migration.js added to grunt tasks (fixes #3632) (#3633)
630e6ab 
* New: migration.js added to grunt tasks (fixes #3632)

* added file missed.

* Revert "New: migration.js added to grunt tasks (fixes #3632)"

This reverts commit b275bce.

* Delete RUB_README.md

* Typo

* Fix: Reenable testing (#3644)

* Removed now unnecessary supplementEntry (#3645)

* removed unnecessary comments

* package.json

* updated package lock

* moved from devdependency to dependency

* Fix: Allow migration:test --file to take globs

* Migrations, allow simple includes with --file= argument

---------

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@semantic-release-bot
Chore(release): 5.43.0 [skip ci]
e787357 
# [5.43.0](v5.42.7...v5.43.0) (2025-03-17)

### New

* migration.js added to grunt tasks (fixes #3632) (#3633) ([630e6ab](630e6ab)), closes [#3632](#3632) [#3633](#3633) [#3632](#3632) [#3632](#3632) [#3644](#3644) [#3645](#3645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverfoster @cahirodoherty-learningpool @joe-allen-89