Skip to content

Fix: Test output (fixes #38) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 2 commits into from
Mar 3, 2025
Merged

Fix: Test output (fixes #38) #39

oliverfoster merged 2 commits into from
Mar 3, 2025

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 24, 2025 •
edited
Loading

Fix

  • Test execution label is clearer
  • Summary of changes correctly prints for each unique_id when _type is missing from content
  • Summary of changes reports no changes rather than a blank table
  • Defaults were added for missing context elements
  • Deep clone test content to prevent mutation of data passed by refence

@oliverfoster oliverfoster self-assigned this Feb 24, 2025
joe-allen-89
joe-allen-89 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely with a tweek to the migration task.

@oliverfoster
Copy link
Member Author

oliverfoster commented Feb 25, 2025

I think I did that in the outstanding framework pr at adaptlearning/adapt_framework@8ca9917

adaptlearning/adapt_framework#3633

@joe-allen-89
Copy link
Contributor

joe-allen-89 commented Feb 25, 2025

You did, I just hadn't pulled the updated branch apparently.

@oliverfoster oliverfoster merged commit 360f859 into master Mar 3, 2025
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 3, 2025
@oliverfoster oliverfoster deleted the issue/38 branch March 3, 2025 15:39
github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
@semantic-release-bot
Chore(release): 1.1.1 [skip ci]
1cb5fa1 
## [1.1.1](v1.1.0...v1.1.1) (2025-04-23)

### Fix

* Added automation ([5c26fc9](5c26fc9))
* Added color, fixed passed or failed status, differentiate summary by type (fixes #40) (#41) ([e1cdf58](e1cdf58)), closes [#40](#40) [#41](#41)
* Check for null value (#47) ([04de80a](04de80a)), closes [#47](#47)
* Summary table line numbers ([af20741](af20741))
* Test output (fixes #38) (#39) ([360f859](360f859)), closes [#38](#38) [#39](#39)
* Use semver.valid for addPlugin and updatePlugin (fixes #36) (#37) ([8f30fbd](8f30fbd)), closes [#36](#36) [#37](#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverfoster @joe-allen-89