Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/jumanji support #136

Merged
merged 15 commits into from
Jan 13, 2023
Merged
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ DOCKER_IMAGE_NAME = instadeep/qdax:$(USER)
USER_ID = $$(id -u)
GROUP_ID = $$(id -g)

PORT = 8888

# Makefile
.PHONY: clean
clean:
Expand All @@ -25,7 +27,7 @@ dev_container: clean build
.PHONY: ipynb_container
ipynb_container: clean build
echo "Make sure you have properly exposed your VM before, with the gcloud ssh command followed by -- -N -f -L 8888:localhost:8888"
sudo docker run -p 8888:8888 -it $(DOCKER_RUN_FLAGS) -v $(WORK_DIR):/app $(DOCKER_IMAGE_NAME) jupyter notebook --port=8888 --no-browser --ip=0.0.0.0 --allow-root
sudo docker run -p $(PORT):$(PORT) -it $(DOCKER_RUN_FLAGS) -v $(WORK_DIR):/app $(DOCKER_IMAGE_NAME) jupyter notebook --port=$(PORT) --no-browser --ip=0.0.0.0 --allow-root

.PHONY: style
style: clean
Expand Down
3 changes: 3 additions & 0 deletions docs/api_documentation/tasks.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Tasks

--8<-- "qdax/tasks/README.md"
1 change: 0 additions & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# Welcome to QDax

--8<-- "README.md"
Loading