-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/jumanji support #136
Merged
Merged
Feat/jumanji support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
===========================================
+ Coverage 92.31% 92.41% +0.10%
===========================================
Files 103 105 +2
Lines 5816 5910 +94
===========================================
+ Hits 5369 5462 +93
- Misses 447 448 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Lookatator
reviewed
Jan 10, 2023
Lookatator
reviewed
Jan 10, 2023
Lookatator
reviewed
Jan 10, 2023
Lookatator
reviewed
Jan 10, 2023
Lookatator
reviewed
Jan 10, 2023
Lookatator
reviewed
Jan 10, 2023
Thanks @Lookatator for the comments. I agree with them. I'll update accordingly. |
Lookatator
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #83
This PR aims at easing the use of Jumanji environments in QDax. Jumanji is an open-source Jax package for games and combinatorial optimization problems written as MDPs.
This PR introduces:
Checks
Future improvements
The way the dependencies are handled in readthedocs is quite annoying at the moment, because the installation of qdax overwrites the requirements. We need to udpate our readthedocs file to fix this.