Remove displayio.Group max_size parameter from libraries

[lesamouraipourpre]

Now that max_size has been disabled in shared-bindings/displayio/Group.c ready for removal in CircuitPython 7, it needs to be removed from all the libraries that make use of it before this can happen.

circuitpython/shared-bindings/displayio/Group.c

Line 45 in 37c5211

//| :param int max_size: Ignored. Will be removed in 7.x.

I propose to work through the libraries and make the necessary PRs. This Issue is intended as a central tracking point which will eventually allow the removal of the parameter from shared-bindings, hopefully before the release-candidate of CP7.

• Adafruit_CircuitPython_CLUE - Remove max_size parameter Adafruit_CircuitPython_CLUE#45
• Adafruit_CircuitPython_CursorControl - Remove max_size parameter Adafruit_CircuitPython_CursorControl#24
• Adafruit_CircuitPython_Dash_Display - Remove max_size parameter Adafruit_CircuitPython_Dash_Display#2
• Adafruit_CircuitPython_Display_Button - Remove max_size parameter Adafruit_CircuitPython_Display_Button#31
• Adafruit_CircuitPython_Display_Shapes - Remove max_size parameter Adafruit_CircuitPython_Display_Shapes#38
• Adafruit_CircuitPython_Display_Text - Remove max_size parameter Adafruit_CircuitPython_Display_Text#153
• Adafruit_CircuitPython_DisplayIO_Layout - Remove max_size parameter Adafruit_CircuitPython_DisplayIO_Layout#40
• Adafruit_CircuitPython_DisplayIO_SH1106 - Remove max_size parameter Adafruit_CircuitPython_DisplayIO_SH1106#4
• Adafruit_CircuitPython_DisplayIO_SH1107 - Remove max_size parameter Adafruit_CircuitPython_DisplayIO_SH1107#6
• Adafruit_CircuitPython_DisplayIO_SSD1305 - Remove max_size parameter Adafruit_CircuitPython_DisplayIO_SSD1305#12
• Adafruit_CircuitPython_DisplayIO_SSD1306 - Remove max_size parameter Adafruit_CircuitPython_DisplayIO_SSD1306#21
• Adafruit_CircuitPython_FRAM - Not displayio.Group
• Adafruit_CircuitPython_Gizmo - Remove max_size parameter Adafruit_CircuitPython_Gizmo#19
• Adafruit_CircuitPython_HX8357 - Remove max_size parameter Adafruit_CircuitPython_HX8357#15
• Adafruit_CircuitPython_ILI9341 - Remove max_size parameter Adafruit_CircuitPython_ILI9341#27
• Adafruit_CircuitPython_ImageLoad - Remove max_size parameter Adafruit_CircuitPython_ImageLoad#54
• Adafruit_CircuitPython_MONSTERM4SK - Remove max_size parameter Adafruit_CircuitPython_MONSTERM4SK#8
• Adafruit_CircuitPython_PortalBase - Remove max_size parameter Adafruit_CircuitPython_PortalBase#42
• Adafruit_CircuitPython_ProgressBar - Remove max_size parameter Adafruit_CircuitPython_ProgressBar#32
• Adafruit_CircuitPython_PyBadger - Remove max_size parameter Adafruit_CircuitPython_PyBadger#45
• Adafruit_CircuitPython_PYOA - Remove max_size parameter Adafruit_CircuitPython_PYOA#23
• Adafruit_CircuitPython_SSD1325 - Remove max_size parameter Adafruit_CircuitPython_SSD1325#11
• Adafruit_CircuitPython_SSD1327 - Remove max_size parameter Adafruit_CircuitPython_SSD1327#10
• Adafruit_CircuitPython_SSD1331 - Remove max_size parameter Adafruit_CircuitPython_SSD1331#14
• Adafruit_CircuitPython_SSD1351 - Remove max_size parameter Adafruit_CircuitPython_SSD1351#16
• Adafruit_CircuitPython_ST7735 - Remove max_size parameter Adafruit_CircuitPython_ST7735#15
• Adafruit_CircuitPython_ST7735R - Remove max_size parameter Adafruit_CircuitPython_ST7735R#25
• Adafruit_CircuitPython_ST7789 - Remove max_size parameter Adafruit_CircuitPython_ST7789#23
• Adafruit_CircuitPython_turtle - Remove max_size parameter Adafruit_CircuitPython_turtle#24
• Check Community Bundle
• Community/drivers/gc9a01 - Remove max_size parameter tylercrumpton/CircuitPython_GC9A01#2
• Community/drivers/ili9163 - Remove max_size parameter electronut/Electronutlabs_CircuitPython_ILI9163#2
• Community/helpers/arrowline - https://github.com/jposada202020/CircuitPython_ArrowLine/releases/tag/0.8.1
• Community/helpers/candlesticks - https://github.com/jposada202020/CircuitPython_Candlesticks/releases/tag/0.6.1
• Community/helpers/circuitpython_display_frame - Remove max_size parameter FoamyGuy/CircuitPython_Display_Frame#1
• Community/helpers/styles - https://github.com/jposada202020/CircuitPython_styles/releases/tag/0.5.1
• Check CircuitPythonOrg Bundle
• CPO/DisplayIO_Annotation - Remove max_size parameter circuitpython/CircuitPython_Org_DisplayIO_Annotation#4
• CPO/DisplayIO_Cartesian - Remove max_size parameter circuitpython/CircuitPython_Org_DisplayIO_Cartesian#4
• CPO/DisplayIO_FlipInput - Remove max_size parameter circuitpython/CircuitPython_Org_DisplayIO_FlipInput#3
• CPO/DisplayIO_SwitchRound - Remove max_size parameter circuitpython/CircuitPython_Org_DisplayIO_SwitchRound#6

Below is the output of grep -r max_size * | grep -v adafruit_fram | sort against Adafruit_CircuitPython_Bundle/libraries at Fri 16 Jul 17:03:22 BST 2021

drivers/displayio_sh1106/examples/displayio_sh1106_simpletest.py:splash = displayio.Group(max_size=10)
drivers/displayio_sh1106/README.rst:    splash = displayio.Group(max_size=10)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:left_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:right_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    right_group = displayio.Group(max_size=4)
drivers/ssd1325/examples/ssd1325_simpletest.py:    max_size=10,
drivers/ssd1325/examples/ssd1325_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_left = displayio.Group(max_size=10, scale=1, x=0, y=6)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_right = displayio.Group(max_size=10, scale=1, x=80, y=6)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=64)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/README.rst:    splash = displayio.Group(max_size=10)

[FoamyGuy]

Thanks for putting this together. We'll need to run a similar pass through the learn guide repo to change instances of this as well.

[jposada202020]

@lesamouraipourpre I give all the thanks here for all these PRs. This is hard work!!!