Remove max_size parameter #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
FoamyGuy
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
looks good to me. Tested all examples on PyPortal with
Adafruit CircuitPython 7.0.0-alpha.4 on 2021-07-08; Adafruit PyPortal with samd51j20
Noticed an issue with IconWidget and IconAnimated, but I do not think it's related to this change specifically. Will work on trying to make a smaller reproduction of the issue containing only what is necessary to see it happen.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 11, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.10.0 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#40 from lesamouraipourpre/max-size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of the
max_sizeparameter now that it has been disabled inshared-bindings.The examples have been tested on a Pynt: