Skip to content

Remove max_size parameter #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2021
Merged

Remove max_size parameter #54

merged 2 commits into from
Jul 2, 2021

Conversation

@lesamouraipourpre
Copy link
Contributor

Remove the max_size parameter. It is no longer used by displayio.Group
Ref: adafruit/circuitpython#4959

Updated example tested on a Pynt (with modifications for PyPortal screen):

Adafruit CircuitPython 6.3.0 on 2021-06-01; Adafruit PyPortal with samd51j20

@lesamouraipourpre lesamouraipourpre mentioned this pull request Jul 2, 2021
Closed
41 tasks
FoamyGuy
FoamyGuy approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Tested successfully the updated example with a tweak to use board.DISPLAY with PyGamer on 6.3.0

@FoamyGuy FoamyGuy merged commit 071d6e8 into adafruit:main Jul 2, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 3, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5b7e4de)
661440d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.2.0 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#38 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.15.1 from 1.15.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#54 from lesamouraipourpre/max-size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesamouraipourpre @FoamyGuy