Fix logging #1074
Open
Fix logging #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue that the stale action finds in this log excerpt *is* stale, it just isn't marked that way yet. Saying that the issue isn't stale is misleading and contradictory. https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 [actions#2] Found this issue last updated at: 2023-08-09T14:33:12Z ... [actions#2] This issue is not stale ... [actions#2] This issue should be stale based on the last update date the 09-08-2023 (2023-08-09T14:33:12Z) [actions#2] This issue should be marked as stale based on the option days-before-issue-stale (https://github.com/actions/stale#days-before-issue-stale) (1) [actions#2] Marking this issue as stale
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 ... [actions#2] Removing all the labels specified via the labels-to-remove-when-stale (https://github.com/actions/stale#labels-to-remove-when-stale) option. [actions#2] Removing the label "label-to-add-when-unstale" from this issue... Error: [actions#2] Error when removing the label: "Label does not exist" The quotes on this last line make it look like the action was trying to remove a label named `Label does not exist`. This change removes the quotes to make it clear that the text is just an error message (which is implied by the `:`) as opposed to the name of a label, which is the reading one gets from the inclusion of additional quotes around the text.
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:56 Processing the batch of issues actions#1 containing 3 issues... ::group::[actions#3] Pull request actions#3 [actions#3] Pull request actions#3 ... ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 ... ::group::[actions#1] Issue actions#1 [actions#1] Issue actions#1 ... Batch actions#1 processed. No more issues found to process. Exiting... Statistics: Processed items: 3 ├── Processed issues: 2 └── Processed PRs : 1 Clearly this action sometimes understands that users do not view all items as issues. This change applies the `items` nomenclature to this initial logging.
|
Hello @jsoref for your efforts, we are starting to review the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The logging is really frustrating.
I created a run that covers 3 items (2 issues and 1 PR): https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430
items, but a lot of the code doesn't.Related issue:
Add link to the related issue.
Check list: