Fix pr message to be optional #3

shawnnapora · 2019-08-06T22:30:28Z

Fixes #2

damccorm

Good catch

damccorm · 2019-08-07T01:55:37Z

src/main.ts

    let staleMessage = isPr ? args.stalePrMessage : args.staleIssueMessage;
+    if (!staleMessage) {
+      continue;


Might be helpful to have a debug statement here saying we skipped something.

https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:56 Processing the batch of issues actions#1 containing 3 issues... ::group::[actions#3] Pull request actions#3 [actions#3] Pull request actions#3 ... ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 ... ::group::[actions#1] Issue actions#1 [actions#1] Issue actions#1 ... Batch actions#1 processed. No more issues found to process. Exiting... Statistics: Processed items: 3 ├── Processed issues: 2 └── Processed PRs : 1 Clearly this action sometimes understands that users do not view all items as issues. This change applies the `items` nomenclature to this initial logging.

fix pr message to be optional

1aa89de

shawnnapora requested a review from damccorm August 6, 2019 22:30

damccorm approved these changes Aug 7, 2019

View reviewed changes

added debug

9e2da93

shawnnapora merged commit 27d7ba7 into master Aug 7, 2019

shawnnapora deleted the optional-pr branch August 7, 2019 13:32

Provide feedback