Stale PR message required, but should be optional #2
Assignees
Comments
jsoref
added a commit
to jsoref/stale
that referenced
this issue
Aug 11, 2023
The issue that the stale action finds in this log excerpt *is* stale, it just isn't marked that way yet. Saying that the issue isn't stale is misleading and contradictory. https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 [actions#2] Found this issue last updated at: 2023-08-09T14:33:12Z ... [actions#2] This issue is not stale ... [actions#2] This issue should be stale based on the last update date the 09-08-2023 (2023-08-09T14:33:12Z) [actions#2] This issue should be marked as stale based on the option days-before-issue-stale (https://github.com/actions/stale#days-before-issue-stale) (1) [actions#2] Marking this issue as stale
jsoref
added a commit
to jsoref/stale
that referenced
this issue
Aug 11, 2023
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 ... [actions#2] Removing all the labels specified via the labels-to-remove-when-stale (https://github.com/actions/stale#labels-to-remove-when-stale) option. [actions#2] Removing the label "label-to-add-when-unstale" from this issue... Error: [actions#2] Error when removing the label: "Label does not exist" The quotes on this last line make it look like the action was trying to remove a label named `Label does not exist`. This change removes the quotes to make it clear that the text is just an error message (which is implied by the `:`) as opposed to the name of a label, which is the reading one gets from the inclusion of additional quotes around the text.
jsoref
added a commit
to jsoref/stale
that referenced
this issue
Aug 11, 2023
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:56 Processing the batch of issues actions#1 containing 3 issues... ::group::[actions#3] Pull request actions#3 [actions#3] Pull request actions#3 ... ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 ... ::group::[actions#1] Issue actions#1 [actions#1] Issue actions#1 ... Batch actions#1 processed. No more issues found to process. Exiting... Statistics: Processed items: 3 ├── Processed issues: 2 └── Processed PRs : 1 Clearly this action sometimes understands that users do not view all items as issues. This change applies the `items` nomenclature to this initial logging.
jsoref
added a commit
to jsoref/stale
that referenced
this issue
Aug 11, 2023
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 [actions#2] Found this issue last updated at: 2023-08-09T14:33:12Z ... [actions#2] Marking this issue as stale [actions#2] This issue is now stale [actions#2] This issue is already stale At this point, things are already pretty bad. The issue wasn't _already_ stale, it was _just marked_ stale. There was a lot of code trying to keep this state in mind, and it yields some really lousy outcomes... [actions#2] Checking for label on this issue [actions#2] Issue marked stale on: 2023-08-11T03:11:21Z [actions#2] Checking for comments on issue since: 2023-08-11T03:11:21Z Great, so, while the workflow is running, it's looking to see if any new comments have arrived since the workflow itself marked the issue as stale. The odds of there being any are very close to 0, and really there's no point in checking now, it makes much more sense to check the _next_ time the workflow runs. [actions#2] Comments that are not the stale comment or another bot: 0 [actions#2] Issue has been commented on: false [actions#2] Days before issue close: 3 [actions#2] The option remove-stale-when-updated (https://github.com/actions/stale#remove-stale-when-updated) is: true [actions#2] The stale label should not be removed [actions#2] marked stale this run, so don't check for updates Here we finally think about the fact that we're in this edge case. The only thing that makes sense to keep, and which is moved by this change is: [actions#2] Removing all the labels specified via the labels-to-remove-when-stale (https://github.com/actions/stale#labels-to-remove-when-stale) option. [actions#2] Removing the label "label-to-add-when-unstale" from this issue... Error: [actions#2] Error when removing the label: "Label does not exist" We return to nonsensical tasks: [actions#2] Issue has been updated since it was marked stale: false [actions#2] Issue has been updated in the last 3 days: true [actions#2] Stale issue is not old enough to close yet (hasComments? false, hasUpdate? true) Note that it's a really rude behavior to mark an item as stale and close it in the same action. BEHAVIOR CHANGE: This change will force action users to trigger two workflow runs if they want to retain that rude behavior. [actions#2] 5 operations consumed for this issue ::endgroup::
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: