Skip to content

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Nov 8, 2022

Prevent package-lock.json to be automatically regenerated with npm install to have more stable builds.

  • enable package-lock.json tracking (recommended practice)
  • replace npm install with npm ci to achieve fast and reproducible builds
  • strict packages versions from package-lock.json are now used for install. To propagate a change made into package.json, run npm install and commit the new package-lock.json.
  • any version disagrement between package.json and package-lock.json will trigger an error.

@laemtl laemtl requested a review from maltheism November 8, 2022 18:34
@laemtl laemtl requested a review from maltheism November 9, 2022 18:58
@driusan
Copy link
Collaborator

driusan commented Nov 10, 2022

Can you rebase? I just want to be sure it still passes after I just merged the 24.1->main PR.

@driusan driusan merged commit 1d3a4d0 into aces:main Nov 11, 2022
@laemtl laemtl mentioned this pull request Dec 20, 2022
driusan pushed a commit that referenced this pull request Dec 20, 2022
Fix a regression introduced by #8224
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants