Skip to content

Commit 1d3a4d0

Browse files
authored
[npm] reproducible builds (#8224)
Prevent package-lock.json to be automatically regenerated with npm install to have more stable builds. - enable package-lock.json tracking (recommended practice) - replace npm install with npm ci to achieve fast and reproducible builds - strict packages versions from package-lock.json are now used for install. To propagate a change made into package.json, run npm install and commit the new package-lock.json. - any version disagrement between package.json and package-lock.json will trigger an error.
1 parent 8a6086d commit 1d3a4d0

File tree

6 files changed

+28161
-8
lines changed

6 files changed

+28161
-8
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,4 @@ SQL/Archive/autogenerated/single_use/*.sql
3333
SQL/Archive/autogenerated/*.sql
3434
VERSION
3535
.DS_Store
36-
package-lock.json
3736
.eslintcache

Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,24 @@ VERSION: .
1010
phpdev:
1111
composer install
1212

13-
javascript:
13+
jsdev:
14+
npm ci
15+
npm run compile
16+
17+
jslatest: clean
18+
rm -rf package-lock.json
19+
rm -rf modules/electrophysiology_browser/jsx/react-series-data-viewer/package-lock.json
1420
npm install
1521
npm run compile
1622

17-
dev: VERSION phpdev javascript
23+
dev: VERSION phpdev jsdev
1824

1925
clean:
2026
rm -f smarty/templates_c/*
2127
rm -f VERSION
2228
rm -rf vendor
2329
rm -rf node_modules
24-
rm -f package-lock.json
2530
rm -rf modules/electrophysiology_browser/jsx/react-series-data-viewer/node_modules
26-
rm -f modules/electrophysiology_browser/jsx/react-series-data-viewer/package-lock.json
2731

2832
# Perform static analysis checks
2933
checkstatic: phpdev

docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/CentOS/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ In addition to the above, the following packages should be installed with `yum`
1919

2020
* [Composer](https://getcomposer.org)
2121

22-
* NodeJS 16.10.0 or higher
22+
* NodeJS 16.10.0 (or higher)
2323

24-
* NPM >= 8.0
24+
* NPM 8.19.2 (or higher)
2525

2626
* make
2727

docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/Ubuntu/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Additionally, the following package manager are required to build LORIS:
2424

2525
* NodeJS 16.10.0 (or higher)
2626

27-
* NPM
27+
* NPM 8.19.2 (or higher)
2828

2929
* composer
3030

0 commit comments

Comments
 (0)