[data_release] Version column sort - fix #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongtiaowang
changed the title
kongtiaowang
added
24.0.0-bugs
xlecours
requested changes
Dec 16, 2021
Contributor
xlecours
left a comment
xlecours
left a comment
There was a problem hiding this comment.
This is affecting multiple module and handles numbers as strings. The sorting of the No. columns is wrong.
Member
|
Hi @kongtiaowang, it seems like version gets set to "Unversioned" when leaving version blank while uploading. I'm unsure if it's supposed to be sorted with the alphabetical versions as well? |
Contributor
Author
|
Add "Unversioned" into sorting. |
Contributor
|
What is the status @kongtiaowang ? |
Contributor
Author
|
@xlecours it is ready. |
Member
|
Hi @kongtiaowang test suite is failing maybe rebase fix? |
kongtiaowang
removed
the
24.0.0-bugs
Contributor
Author
|
This PR is ready to test and code review again. |
Contributor
|
@kongtiaowang Can you rebase this PR? The JS compilation is broken and PR #8224 should fix this issue. |
remove outdate change
Contributor
Author
|
@xlecours you are right, the core jsx/DataTable.js should not change here. Please review it again. |
xlecours
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
transfer the int value to string to sort the mix type column. { 1 , version2 , v3}
add Unversioned into sorting.
Testing instructions (if applicable)
sort the version column
Link(s) to related issue(s)
[data_release] Version column only sorts in 1 direction #7894