exclude reports that indicate a healthy status #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Expecho , Thanks for contributing this, a new release build is on appveyor, when finish a new package for AI publisher version 2.2.3 will be on NuGet! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #138 that makes it possible to configure the Application Insights publisher to only publish reports that indicate an unhealthy state by adding an optional flag
excludeHealthyReports.When the publisher is configured to publish the details (using
saveDetailedReport) only those detailed reports indicating an unhealthy state will be published ifexcludeHealthyReportsis set totrueI am all open for creating a functional test for this (as there are none for this particalur publisher) but I would like to add a dependency to Moq or NSubstitute in order to be able to fake the application insights classes involved. If that is ok with you I can add those tests, otherwise I need to figure out other ways.