Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7 Series Release! #1593

Closed
sungam3r opened this issue Dec 22, 2022 · 44 comments
Closed

V7 Series Release! #1593

sungam3r opened this issue Dec 22, 2022 · 44 comments
Milestone
V7 Release

Comments

@sungam3r
Copy link
Collaborator

sungam3r commented Dec 22, 2022 •
edited
Loading

So far all projects and CI/CD pipelines have been updated to use the latest-and-greatest .NET7. A lot of dependencies were changed to the latest versions, i.e. bumping major versions.

Pain points:

  • UI projects, CI for UI does not call dotnet test
  • Docker/K8S stuff - it all needs review
  • KubernetesClient nuget package is very old - v4.0.26 (09.04.2021) vs 10.0.1 on nuget.org
  • A lot of pending/abandoned PRs without feedback. Many of them look good and I would merge them before v7 release. Of course after resolving conflicts and review.

For now we can release preview versions of all packages listed in that repo and collect feedback.

This issue is pinned to take addition attention from community. ping @carlosrecuero @unaizorrilla

Comments are appreciated!

UPDATED:

  • V7 is ready!
  • Full list of changes starts here and it was too large that I had to split it into 5 parts. GitHub release/comment UI did not accept such huge value of text.
@sungam3r sungam3r pinned this issue Dec 22, 2022
@sungam3r sungam3r added this to the V7 Release milestone Dec 22, 2022
@sungam3r
Copy link
Collaborator Author

It will also be great to get proposals about what issues should be included in V7 milestone.

@sungam3r sungam3r added the help wanted Extra attention is needed label Dec 22, 2022
@sungam3r
Copy link
Collaborator Author

@carlosrecuero @unaizorrilla I looked through all the open PRs and asked their authors to update them pulling changes from master. Some of PRs have already passed review. Help in UI/docker/K8s stuff is appreciated.

@sungam3r
Copy link
Collaborator Author

All 7.0.0-preview packages have been published. Example - https://www.nuget.org/packages/AspNetCore.HealthChecks.UI/7.0.0-rc2.6

@sungam3r sungam3r mentioned this issue Dec 29, 2022
Merged
6 tasks
@lkurzyniec lkurzyniec mentioned this issue Jan 22, 2023
Merged
@lkurzyniec
Copy link

Are you gonna to upgrade version of Microsoft.Data.SqlClient to the newest stable version 5.1.0 in this release?
WhiteSource is rising vulnerability issue related to that dependency (lkurzyniec/netcore-boilerplate#100).

@sungam3r
Copy link
Collaborator Author

#1647

@sungam3r sungam3r mentioned this issue Feb 3, 2023
Closed
sungam3r referenced this issue Feb 3, 2023
@DPDmancul
Construct RabbitMQHealthCheck only from options
bd391d0
@lkurzyniec
Copy link

Any ETA for this one?

@sungam3r
Copy link
Collaborator Author

sungam3r commented Feb 27, 2023 •
edited
Loading

Nope. I'm not the "core repo maintainer" and I'm still waiting feedback. @carlosrecuero @CarlosLanderas and @unaizorrilla are. Honestly, I have not received feedback from them for that repo for a very long time. Techically I can make a release at any time - it's just 2 clicks to set release-all-7.0.0 tag.

Why didn't I make a release yet? See pain points in my initial comment. I do not use 100% of this repo. Actually I even do not know how it works, I have never tried to start UI bits, open dashboards, dive into databases integration, etc. I don’t know if everything works there after the changes made.

@sungam3r
Copy link
Collaborator Author

Rel: #1714

@unaizorrilla
Copy link
Collaborator

I’m trying to find some time to get up de UI next week…

You can release v7 package for health checks, no the UI?

@lkurzyniec lkurzyniec mentioned this issue Feb 27, 2023
Closed
@sungam3r
Copy link
Collaborator Author

sungam3r commented Feb 27, 2023 •
edited
Loading

Thanks. I configured CI in such a way that we can publish packages one by one or all packages in the same time. I would just wait.

@sungam3r
Copy link
Collaborator Author

Also please pay attention to #1712.

@sungam3r sungam3r mentioned this issue Mar 1, 2023
Merged
6 tasks
@marioleed
Copy link
Contributor

Could we start realeasing V7 versions of the packages that don't have an issue?

@sungam3r
Copy link
Collaborator Author

that don't have an issue

What issue?

@marioleed
Copy link
Contributor

I'm referring to the "pain points" you mentioned in a previous comment and also if there are any issues (tasks) preventing packages from being released.

Pain points:

UI projects, CI for UI does not call dotnet test
Docker/K8S stuff - it all needs review
KubernetesClient nuget package is very old - v4.0.26 (09.04.2021) vs 10.0.1 on nuget.org
A lot of pending/abandoned PRs without feedback. Many of them look good and I would merge them before v7 release. Of course after resolving conflicts and review.

Then regarding to @unaizorrilla's comment:

You can release v7 package for health checks, no the UI?

And your response:

I configured CI in such a way that we can publish packages one by one or all packages in the same time. I would just wait.

Given above; could we start realeasing V7 versions of the packages that don't have an issue?

@sungam3r
Copy link
Collaborator Author

Technically yes, but I think it will raise questions from consumers rather quickly if they find themselves with mix from v7 and v6 packages. I'm 50/50 here honestly.

@sungam3r sungam3r mentioned this issue Apr 5, 2023
Closed
@sungam3r
Copy link
Collaborator Author

sungam3r commented Jul 3, 2023

Hi all. Since the lack of feedback from core repo maintainers for more than 6 months I'll publish v7 release in coming days (despite the aforementioned problems) after I see the accumulated mail. The plan is to solve problems with v7 release as they appear.

This was referenced Jul 3, 2023
Closed
Open
Closed
@sungam3r
Copy link
Collaborator Author

sungam3r commented Jul 5, 2023

Heads up! For all devs interested in v7 - if you have proposals for making changes to v7, now it's time to say about it or/and post PRs / revive existing ones, because after the release I will not be inclined to make backward incompatible changes for some (potentially long) time. I think that in the absence of significant proposals, the release will be published at the end of this week.

@sungam3r
Copy link
Collaborator Author

sungam3r commented Jul 7, 2023 •
edited
Loading

So... PRs left to merge in v7:

@sungam3r
Copy link
Collaborator Author

sungam3r commented Jul 7, 2023

@cieciurm I added "needs confirmation" label on 3 more PRs. Also you can look into other PRs mentioned above.

@cieciurm
Copy link
Contributor

cieciurm commented Jul 7, 2023

I can look into those 3 labeled next week - I can't promise more (this week I was able to work on 3 as well).

So the ETA is next Friday 14th of July :)

@cieciurm
Copy link
Contributor

cieciurm commented Jul 11, 2023 •
edited
Loading

I can see a progress in terms of closing hanging PR-s 🎉 !

I see we have just a couple of them left.
I can't really help with the Docker one, since I'm no expert. Also the RabbitMQ is mentioned as maybe.

@sungam3r what is your opinion on the next steps before V7 release?

Should we try to close all from the list you have pasted above?

We also have 9 issues labeled as "Up for grabs", but not sure if we wanna extend the scope?

@sungam3r
Copy link
Collaborator Author

I use up-for-grabs tag for easy tasks (easy in my opinion) so anyone can accomplish them. I would like to deal with all issues from my comment above and not interfere with up-for-grabs issues. But I'm fine to go another way and try to deal with those 9 issues. Of course at the cost of additional time. I have no much time these days because of household chores.

@cieciurm
Copy link
Contributor

cieciurm commented Jul 12, 2023 •
edited
Loading

So... PRs left to merge in v7:

  1. [DONE] Add overload to AddAzureBlobStorage to supply your own BlobServiceClient from delegate #1845
  2. [DONE] Added MySQL HealthChecks Query and Callback support. #1835
  3. [DONE] Less allocations in HealthChecks.Network #1814
  4. [DONE] Allow to add config.json to docker #1716 (maybe)
  5. [DONE] add RequestTimeout as option for RavenDB healthcheck #1707
  6. [TO DO] Add ClickHouse DataBase HealthCheck #1660
  7. [DONE] Allow healthchecking multiple RabbitMQ connections #1659 (maybe)
  8. [DONE] Bump bumpalo from 3.2.1 to 3.12.0 in /deploy/operator/installer #1648
  9. [DONE] Fix bug with regression of datetime string in OnStateFrom column in UI #836
  10. [DONE] Feature/support azure appinsights #740
  11. [DONE] Fix should_return_too_many_requests_status_using_default_server_max_active_requests flaky test #1882

So to sum up:

  • Ad 2) PR is almost completed
  • Ad 3) You have started a PR
  • Ad 4) To do - as I said, I'm not so familiar with Docker
  • Ad 6) You have started a PR
  • Ad 7) Requires a PR revival - I can look into this
  • Ad 8) Just a dependabot update[?]

Let's keep coding 🤘🏻 😄

@sungam3r
Copy link
Collaborator Author

Also #1869

@rob-baldwin rob-baldwin mentioned this issue Jul 18, 2023
Closed
@sungam3r
Copy link
Collaborator Author

Issues left

@cieciurm
Copy link
Contributor

Issues left

I see that you have the first one covered (PR in-progress).
The second one is something Docker specific, which I don't fully understand and have no clue, how to approach.

So - almost there 🎉 🎊 😄

@sungam3r
Copy link
Collaborator Author

Anyone, help with #1716 is appreciated.

@sungam3r
Copy link
Collaborator Author

I want to briefly sort out pending issues before v7 release, 93 left.

@sungam3r
Copy link
Collaborator Author

Also I decided skip #1660 and handle it later.

@sungam3r sungam3r mentioned this issue Jul 24, 2023
Closed
@sungam3r
Copy link
Collaborator Author

Pending:

@cieciurm You may take case of #1943 if you want.

I want to briefly sort out pending issues before v7 release, 93 left.

Done. I think we are ready to release v7 after merging aforementioned 2 PRs.

@cieciurm
Copy link
Contributor

cieciurm commented Jul 30, 2023 •
edited
Loading

Because you've pinged the original author in the PR, let's wait until end of Tuesday (August 1st). If it's not adjusted, I'll do it myself :shipit:

@sungam3r
Copy link
Collaborator Author

изображение

😄

@sungam3r
Copy link
Collaborator Author

What's Changed [part 1]

@sungam3r
Copy link
Collaborator Author

What's Changed [part 2]

@sungam3r
Copy link
Collaborator Author

What's Changed [part 2]

@sungam3r
Copy link
Collaborator Author

sungam3r commented Jul 30, 2023 •
edited
Loading

What's Changed [part 3]

@sungam3r
Copy link
Collaborator Author

What's Changed [part 4]

@sungam3r
Copy link
Collaborator Author

What's Changed [part 5]

New Contributors

Full Changelog: https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/commits/release-all-7.0.0

@sungam3r
Copy link
Collaborator Author

Thanks to all participants!

@sungam3r sungam3r unpinned this issue Jul 30, 2023
@sungam3r sungam3r removed the help wanted Extra attention is needed label Jul 30, 2023
@cmeeren
Copy link

cmeeren commented Aug 8, 2023 •
edited
Loading

Could you highlight the breaking changes (assuming there are some since the major version was bumped)? I need to make sure I can safely update, and searching the lists above for "breaking" did not give any relevant results.

@NielsPilgaard
Copy link
Contributor

The major version was bumped to stay consistent with dotnet versioning, there have been no breaking changes to my knowledge.

That being said, if you're using dotnet 6 I recommend waiting for #1980 to be merged, before you update to v7

@cmeeren
Copy link

cmeeren commented Aug 8, 2023

Thanks for the clarification! Using .NET 7, so I'll go ahead and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V7 Release
Development

No branches or pull requests
7 participants
@unaizorrilla @cieciurm @marioleed @lkurzyniec @cmeeren @sungam3r @NielsPilgaard