Create option to publish only healthreports reporing a failure

[Expecho]

Given the AddApplicationInsightsPublisher() method, I would love to have it support a flag indicating only reports indicating a failure are send to Application Insights. I am only interested in the amount of failures over time and since I am paying for the amount of data ingested I would like to filter out the normal state.

Other option would be to create an ITelemetryProcessor to filter out the items but I'd rather have built-in support.

I am more than willing to create a PR so we can take a closer look at how an implementation might look like.

[unaizorrilla]

You can filter on Application Insights using the status property if you are interested only on failures.

[Expecho]

I understand, but I do pay for that ingested data. So I would prefer to prevent it from entering Application Insights at all (we do have a large application generating high volumes of telemetry).

[unaizorrilla]

You can reduce the amount of data on AI using sampling!

[Expecho]

Also correct, but that might sample out unhealthy reports as well.

[Expecho]

So summarized, this are the current options:

• Sampling, but the drawback here is that unhealthy reports are excluded as well
• Telemetry Filter, best option for now but requires more work
• Filter in the query using the portal, but the drawback here is we still pay for the data we are not interested in and we send data over the wire we do not need/want

So I still see added value for being able to create a flag indicating only reports indicating a failure are send to Application Insights.

[unaizorrilla]

I'm not sure, let me check this with more people on the project and I try to respond you ASAP!

[lfraile]

After talking with @unaizorrilla we think what you propose, @Expecho, makes sense.

Let me a couple of days to work in it.

[unaizorrilla]

or @Expecho you can contribute this?

[Expecho]

@lfraile @unaizorrilla Sure, no problem. I will give it a go later this week!

[Expecho]

@lfraile @unaizorrilla I think we need to discuss the testing part of this proposed change. See the PR for details. I have an idea in my mind but it involves adding an extra dependency.

[lfraile]

Will take a look tomorrow

…

________________________________ De: Peter Bons <notifications@github.com> Enviado: Thursday, April 4, 2019 9:13:13 PM Para: Xabaril/AspNetCore.Diagnostics.HealthChecks Cc: Luis Fraile Hernandez; Mention Asunto: Re: [Xabaril/AspNetCore.Diagnostics.HealthChecks] Create option to publish only healthreports reporing a failure (#138) @lfraile<https://github.com/lfraile> @unaizorrilla<https://github.com/unaizorrilla> I think we need to discuss the testing part of this proposed change. See the PR for details. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#138 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA_5_tiC58YalxRfBBe2OVgSEJAjFmWLks5vdk7IgaJpZM4cU851>.

[unaizorrilla]

Closed by #143