Repository navigation
fix(sycl): revert pseudo-Kahan recurrence and calibrate Arc A380 - #1314
Merged
lusoris merged 9 commits intoSep 6, 2026
Merged
Conversation
lusoris
force-pushed
the
fix/sycl-ssimulacra2-blur-recurrence-and-arc-calibration
branch
3 times, most recently
from
September 5, 2026 23:11
679266c to
debba87
Compare
…ardware validation
…and arc calibration
lusoris
force-pushed
the
fix/sycl-ssimulacra2-blur-recurrence-and-arc-calibration
branch
from
September 6, 2026 02:26
debba87 to
90d7a32
Compare
lusoris
marked this pull request as ready for review
September 6, 2026 02:26
lusoris
deleted the
fix/sycl-ssimulacra2-blur-recurrence-and-arc-calibration
branch
September 6, 2026 02:50
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the PR #865 pseudo-Kahan recurrence in$10^{25}$ , NaNs, and score saturation at 100.0, restoring a stable float32 Charalampidis IIR recurrence matching the CUDA twin. Calibrates the Intel Arc A380 (
core/src/feature/sycl/ssimulacra2_sycl.cppwhich caused pole blow-up tosycl:0x8086:0x56a*andarc:dg2-g10) inscripts/ci/gpu_ulp_calibration.yamlto5.0e-2(places=1) per ADR-0985 Option C, accounting for fp64-less accumulation across the 6-scale pyramid on natural video clips.Type
feat— new featurefix— bug fixperf— performance improvementrefactor— no behavior changedocs— documentation onlytest— test-onlybuild/ci— tooling / infraport— cherry-pick from upstream Netflix/vmafsycl/cuda/simd— backend-specificChecklist
make format && make lintis green locally.meson test -C build./cross-backend-diffand the worst ULP is ≤ 2..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md).!orBREAKING CHANGE:and the migration path is documented below.docs/adr/_index_fragments/<NNNN-slug>.mdand the slug is appended todocs/adr/_index_fragments/_order.txt— do not editdocs/adr/README.mddirectly (regenerated byscripts/docs/concat-adr-index.sh; see ADR-0221).Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with a row in Recently closed (T-SYCL-ARC-SSIMULACRA2-PARITY-2026-06-03).Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Cross-backend numerical results
Deep-dive deliverables (ADR-0108)
docs/research/0985-sycl-parity-divergence-2026-06-03.mdupdated with pseudo-Kahan pole analysis and empirical measurements.docs/adr/0985-sycl-parity-divergence-2026-06-03.mdunder## Alternatives considered(Option C accepted).core/src/feature/sycl/AGENTS.md("ssimulacra2_sycl.cpp IIR recurrence has no running accumulator — never 'Kahan' it").changelog.d/fixed/sycl-ssimulacra2-blur-recurrence.mdadded.docs/rebase-notes.md.Reproducer
Known follow-ups
Step 3 (a SYCL device CI lane so the parity test stops skipping on machines without hardware) is gated on maintainer decision D4; tracked as a TODO in ADR-0985.