Repository navigation
chore(master): release 1.0.0-rc.1 - #1213
Merged
lusoris merged 2 commits intoSep 27, 2026
Merged
Conversation
github-actions
Bot
force-pushed
the
release-please--branches--master--components--vmafx
branch
8 times, most recently
from
September 3, 2026 02:03
9a62d8e to
55bffcc
Compare
This was referenced Sep 3, 2026
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
3 times, most recently
from
September 7, 2026 12:46
ba62e3e to
b6be882
Compare
lusoris
changed the title
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
5 times, most recently
from
September 7, 2026 18:32
57e7709 to
4e362a5
Compare
This was referenced Sep 7, 2026
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
3 times, most recently
from
September 7, 2026 20:49
86be5cb to
433a49a
Compare
lusoris
added a commit
that referenced
this pull request
Sep 7, 2026
…t version
ADR-1151 split the fork's two version numbers and assigned libvmaf.pc's
`Version:` field to the release-please product side, recording the consequence
as cosmetic:
"The one visible consequence is that libvmaf.pc moves from an advertised
3.2.1 to 1.0.0; since no release ever shipped that 3.2.1, no consumer can
be pinned to it."
That inverts the risk. Nothing is pinned to an exact version. Consumers gate on
a LOWER BOUND they compiled in long before this fork existed:
- unpatched upstream FFmpeg's configure carries
`require_pkg_config libvmaf "libvmaf >= 2.0.0" libvmaf.h vmaf_init`
- this fork's own ffmpeg-patches/0004 and /0005 additionally require
`libvmaf >= 3.0.0` for the SYCL, Vulkan and DNN entry points
A 1.x version satisfies neither. The 1.0.0-rc.1 release PR (#1213) failed
FFmpeg Ubuntu gcc, FFmpeg SYCL, FFmpeg macOS clang and Docker Image Build with
Package 'libvmaf' has version '1.0.0-rc.1', required version is '>= 2.0.0'
while libvmaf itself built and installed fine — libvmaf.so.3.0.0 is right there
in the install log. Only the advertised number was wrong.
The blast radius was never CI. Any distribution's unpatched FFmpeg would have
refused to link the fork the moment it advertised 1.0.0, silently undoing the
drop-in property that deliberately keeping libvmaf.so.3 exists to preserve.
`pkg_mod.generate()` now takes `version: vmaf_soname_version`. The product line
still starts at 1.0.0 and still owns the tag, the Python distributions and the
Helm appVersion; it simply no longer reaches libvmaf.pc.
Verified by configuring with the product version set to the exact release
candidate that broke — project(version: '1.0.0-rc.1') — and checking the
generated .pc against the bounds downstream actually uses:
Version: 3.0.0
libvmaf >= 2.0.0 PASS
libvmaf >= 3.0.0 PASS
libvmaf >= 4.0.0 FAIL
docs/development/release.md, the core/meson.build SONAME comment and
docs/development/rust.md all documented the old coupling and are corrected.
docs/rebase-notes.md gains an entry, because upstream Netflix spells this line
`meson.project_version()` and there the two numbers agree — a sync that takes
theirs reintroduces the bug and no unit test can see it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
2 times, most recently
from
September 7, 2026 22:45
a33b439 to
658dba4
Compare
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
3 times, most recently
from
September 16, 2026 17:18
9c8163c to
e69780a
Compare
lusoris
force-pushed
the
release-please--branches--master--components--vmafx
branch
15 times, most recently
from
September 19, 2026 14:00
7964935 to
0d0b506
Compare
This was referenced Sep 20, 2026
Merged
Contributor
|
🤖 Created releases: 🌻 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/VMAFx/vmafx/blob/release-please--branches--master--components--vmafx--release-notes/release-notes.md