Repository navigation
Conversation
…b7ae73) The row sat in "## Open bugs" pointing at uncompensated fp32 accumulation in the 3-pole IIR Charalampidis blur of core/src/feature/sycl/ssimulacra2_sycl.cpp::launch_blur. That defect is not present on master: 8b7ae73 ("fix: iter6 bundle", PR #865, 2026-06-12) added Kahan compensated-summation state (comp_0/comp_1/comp_2) to all three poles of launch_blur<PASS>, which is exactly the row's own closure condition (b). The ledger text was written against dd02029 (PR #852, 2026-06-08 — the calibration-anchor partial fix) and was never refreshed after #865, so the row read as open for three months and cost a re-investigation. Moves the row (one row per bug id) into "## Recently closed", rewritten in past tense and citing 8b7ae73. The residual is recorded as prose, not as a defect: scripts/ci/gpu_ulp_calibration.yaml still carries the sycl:0x8086:0x56a* entry at status: placeholder because no Arc A380 re-measurement has been committed since the fix. That file's comment block and notes: prose still claimed "the IIR does not use Kahan compensation", so they are corrected here too. The ssimulacra2: 5.0e-3 tolerance and core/test/test_sycl_ssimulacra2_parity.c's PARITY_TOL 5e-3 are untouched. Ledger and prose only; no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded — the row is already closed on master.
Rebasing would re-add a second row for the id, which |
lusoris
deleted the
docs/close-t-sycl-arc-ssimulacra2-parity-2026-06-03
branch
September 18, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T-SYCL-ARC-SSIMULACRA2-PARITY-2026-06-03was sitting indocs/state.md"## Open bugs" describing a defect that is not present onmaster. The row names uncompensated fp32 accumulation in the 3-pole IIR Charalampidis blur ofcore/src/feature/sycl/ssimulacra2_sycl.cpp::launch_blur; that was fixed on 2026-06-12 by8b7ae731a("fix: iter6 bundle", PR #865), which added Kahan compensated-summation state to all three poles — exactly the row's own closure condition (b). The ledger text was written againstdd02029f9(PR #852, 2026-06-08, the calibration-anchor partial fix) and was never refreshed, so the row read as open for three months and cost a re-investigation.This PR moves the row into "## Recently closed" (one row per bug id, past tense, citing
8b7ae731a), and corrects the matching stale prose inscripts/ci/gpu_ulp_calibration.yaml, whose comment block still asserted "the IIR does not use Kahan compensation". Ledger and prose only — no behaviour change, no tolerance change.Type
docs— documentation onlyVerification (why the row is closed)
All against
origin/master:git show origin/master:core/src/feature/sycl/ssimulacra2_sycl.cpp | grep -n -i 'kahan'→ "Kahan (compensated) summation for the IIR recurrence state" and "Kahan-corrected IIR state update", both insidelaunch_blur<PASS>, which now carriesfloat comp_0/comp_1/comp_2and the full pattern per pole:const float y0 = (t0 - prev2_0) - comp_0; const float o0 = prev1_0 + y0; comp_0 = (o0 - prev1_0) - y0;(plus the_1/_2twins).git log --oneline -S'Kahan' origin/master -- core/src/feature/sycl/ssimulacra2_sycl.cpp→ single commit8b7ae731a(PR fix: iter6 bundle — 6 fixes (wave32 comment, UBSan, TSAN, vmaf-tune CRF, AI scripts, MCP conformance) #865, 2026-06-12), whose message documents the change as bounding per-iteration error to O(eps^2) without fp64 (ADR-0220 compliant).git log --oneline origin/master -- scripts/ci/gpu_ulp_calibration.yaml→ last touchdd02029f9(chore(bundle): 8 worktree branches drain — docs + sycl-parity + ci-promotion + tune-report #852), i.e. before the fix — which is why the YAML prose is stale.Residual (recorded as prose, not as a defect)
scripts/ci/gpu_ulp_calibration.yamlkeeps thesycl:0x8086:0x56a*entry atstatus: placeholderwithssimulacra2: 5.0e-3, because no Arc A380 re-measurement has been committed since the fix (git show origin/master:testdata/scores_sycl_a380_576.json | grep -c ssimulacra2→ 0). That is an outstanding hardware measurement, not a live code defect. Nothing was loosened:core/test/test_sycl_ssimulacra2_parity.cstill has#define PARITY_TOL 5e-3and the YAML tolerance value is unchanged.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR — the row moves from "## Open bugs" to "## Recently closed", closed by8b7ae731a. Exactly one table row per bug id; the vacated slot carries the usual<!-- ... moved to Recently closed ... -->marker. The related open rowT-SYCL-ARC-ADM2-PARITY-1.1E-4-2026-09-05gained a one-clause pointer so its "same class as the SSIMULACRA2 row" cross-reference no longer sends a reader back to a closed bug.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
docs/research/0985-sycl-parity-divergence-2026-06-03.mdand the closing evidence is inlined in the state.md row.AGENTS.mdinvariant note — no rebase-sensitive invariants. No code, header, or build surface is touched.changelog.d/changed/1325-state-md-close-sycl-arc-ssimulacra2-parity.md;CHANGELOG.mdregenerated byscripts/release/concat-changelog-fragments.sh --write.Reproducer
Known follow-ups
Re-run
./build-sycl/test/test_sycl_ssimulacra2_parityon Arc A380 hardware once a self-hosted DG2-G10 runner exists, then either promote thesycl:0x8086:0x56a*entry tostatus: calibratedwith the measured tolerance, or open a freshdocs/state.mdrow with the post-Kahan number if the delta still exceeds 5e-3. The gate could not be re-run on the audit host: no SYCL build directory and no oneAPI toolchain configured there.