-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added loghandler to handle log messages from the Client Library with … #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. The code looks clean and good. I am just not sure about its purpose. Does it mean that in the driver those internal macros should be used instead of those defined in the rclcpp
library?
The driver should just continue to use macro's defined inside the This is just a handler to handle messages logged inside the client library with ROS2 logging functionality. This means that messages from the client library will be handled the same way as messages logged inside this driver. See logging configuration in the client library. If console_bridge is found on the system when building the client library, logging commands will be done by console bridge. This is currently the case when building the client library together with the ROS2 driver. Therefore these changes wont have any affect until the console_bridge dependency is removed from the client library. I have created a PR for removing this dependency from the client library. Once this dependency has been removed from the client library these changes will log all messages from the client library with ROS2 logging. |
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ROS2 logging
This implementation wont be used until the client libraries macros are updated to not use console_bridge. However once the console bridge dependency has been removed from the client library, messages logged in the client library will be logged with ROS2 logging.
This will also fix issue #107