Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed console_bridge dependency #74

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Jun 9, 2021

As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.

As a log handler has been created for the ROS2 Driver and the ROS Driver, the console bridge dependency is no longer needed. Also in order for the handlers to actually work, we need to build the client library without console bridge.

This shouldn't be merged before the two PR's UniversalRobots/Universal_Robots_ROS_Driver#398 and UniversalRobots/Universal_Robots_ROS2_Driver#126 has been merged

As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.
@fmauch
Copy link
Collaborator

fmauch commented Jun 18, 2021

At a first glimpse, this looks good. I'll postpone this until after the next release containing all the Cartesian features, alright?

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @urmahp

@fmauch
Copy link
Collaborator

fmauch commented Jul 8, 2021

As both mentioned PRs are merged, I would go ahead and merge this.

@fmauch fmauch merged commit 2d7433d into UniversalRobots:master Aug 16, 2021
@urmahp urmahp deleted the ros_build branch August 16, 2021 09:34
urmahp added a commit to urmahp/Universal_Robots_Client_Library that referenced this pull request Sep 5, 2022
As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants