add checks to login shell #200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
non-ascii-shell
branch
5 times, most recently
from
e1e9223 to
f6d6b9b
Compare
simonLeary42
force-pushed
the
non-ascii-shell
branch
from
bb106ac to
5870d27
Compare
simonLeary42
changed the title
simonLeary42
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a WSOD when a user tries to set their login shell with non ascii characters. Also avoids the LDAP warnings generated in testing: https://github.com/UnityHPC/unity-web-portal/actions/runs/14648366156/job/41108067187
It also grays out the submit button when there's no change, when custom shell is empty, when custom shell has leading/trailing whitesapce. All grayed-out reasons are displayed in a
<p>next to the button, just like the "request PI account" button and "request account deletion button". see examples in #202Screen.Recording.2025-04-24.at.2.46.55.PM.mov