Remove custom shell #203
Merged
Remove custom shell #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
added a commit
that referenced
this pull request
Apr 30, 2025
* add check for special characters in login shell * display invalid reason in <p> like the rest of the page * remove comment * update unityuser to do same checks on login shell as frontend does * update CONTRIBUTING.md * add check for empty shell * update tests * update CONTRIBUTING.md * remove custom login shell * remove note from contrib * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the fun alternative to #200
Fixes a WSOD when a user tries to set their login shell with non ascii characters. Also avoids the LDAP warnings generated in testing: https://github.com/UnityHPC/unity-web-portal/actions/runs/14648366156/job/41108067187
It also grays out the submit button when there's no change.
Screen.Recording.2025-04-24.at.3.34.13.PM.mov