separate highlight logic from submit logic

Author: simonLeary42

webroot/panel/account.php

@@ -272,6 +272,7 @@ function getNewLoginShell() {
         }
         return $("#customLoginBox").val();
     }
+
     function isLoginShellValid(x) {
         if (x.trim().length === 0) {
             return false;
@@ -282,21 +283,32 @@ function isLoginShellValid(x) {
         }
         return true;
     }
+
+    function enableOrDisableCustomLoginBoxHighlight() {
+        if (
+            ($("#loginSelector").val() == "Custom") &&
+            !isLoginShellValid($("#customLoginBox").val())
+        ) {
+            $("#customLoginBox").css("box-shadow", "0 0 0 0.3rem rgba(220, 53, 69, 0.25)");
+        } else {
+            $("#customLoginBox").css("box-shadow", "none");
+        }
+    }
+    $("#customLoginBox").on("input", enableOrDisableCustomLoginBoxHighlight);
+    $("#loginSelector").change(enableOrDisableCustomLoginBoxHighlight);
+    enableOrDisableCustomLoginBoxHighlight();
+
     function enableOrDisableSubmitLoginShell() {
-        var submitLoginShell = $("#submitLoginShell");
         var newLoginShell = getNewLoginShell();
         if (!isLoginShellValid(newLoginShell)) {
-            submitLoginShell.attr("disabled", true);
-            $("#customLoginBox").css("box-shadow", "0 0 0 0.3rem rgba(220, 53, 69, 0.25)");
+            $("#submitLoginShell").attr("disabled", true);
             return;
-        } else {
-            $("#customLoginBox").css("box-shadow", "none");
         }
         if (newLoginShell == ldapLoginShell) {
-            submitLoginShell.attr("disabled", true);
+            $("#submitLoginShell").attr("disabled", true);
             return;
         }
-        submitLoginShell.attr("disabled", false);
+        $("#submitLoginShell").attr("disabled", false);
     }
     $("#customLoginBox").on("input", enableOrDisableSubmitLoginShell);
     $("#loginSelector").change(enableOrDisableSubmitLoginShell);