Rename mlagents.envs to mlagents_envs #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
changed the title
chriselion
requested review from
ervteng and
harperj
and removed request for
ervteng
chriselion
commented
Dec 12, 2019
ml-agents-envs/setup.py
Outdated
| packages=[ | ||
| "mlagents_envs", | ||
| "mlagents_envs.communicator_objects", | ||
| ], # Required # TODO SIDE CHANNELS |
There was a problem hiding this comment.
This was a bug waiting to happen - side_channels directory wasn't in the built packages. I'm switching it to automatically find the directories.
ervteng
approved these changes
Dec 13, 2019
delete-merged-branch
bot
deleted the
develop-MLA-426-rename-mlagents.envs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2902, take two. Motivation from the original PR:
I've since enabled mypy --namespace-packages and fixed the errors.
One thing I need to check is that the we can still build packages with this.✅Will also drop a note in the migration guide.✅