Rename mlagents.envs to mlagents_envs

.circleci/config.yml

@@ -137,7 +137,7 @@ jobs:
       - checkout
       - run:
           name: Combine proto files for caching
-          command: cat protobuf-definitions/proto/mlagents/envs/communicator_objects/*.proto > /tmp/proto_deps.txt
+          command: cat protobuf-definitions/proto/mlagents_envs/communicator_objects/*.proto > /tmp/proto_deps.txt
 
       - restore_cache:
           keys:

.pre-commit-config.yaml

@@ -19,17 +19,17 @@ repos:
     -   id: mypy
         name: mypy-ml-agents
         files: "ml-agents/.*"
-        args: [--ignore-missing-imports, --disallow-incomplete-defs, --namespace-packages]
+        args: [--ignore-missing-imports, --disallow-incomplete-defs]
     -   id: mypy
         name: mypy-ml-agents-envs
         files: "ml-agents-envs/.*"
         # Exclude protobuf files and don't follow them when imported
         exclude: ".*_pb2.py"
-        args: [--ignore-missing-imports, --disallow-incomplete-defs,  --namespace-packages]
+        args: [--ignore-missing-imports, --disallow-incomplete-defs]
     -   id: mypy
         name: mypy-gym-unity
         files: "gym-unity/.*"
-        args: [--ignore-missing-imports, --disallow-incomplete-defs,  --namespace-packages]
+        args: [--ignore-missing-imports, --disallow-incomplete-defs]
 
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.4.0

.pylintrc

@@ -37,10 +37,8 @@ disable =
     # W0703: Catching too general exception Exception
     W0703,
 
-    # E0401: Unable to import...
-    # E0611: No name '...' in module '...'
-    # need to look into these, probably namespace packages
-    E0401, E0611,
+    # E0401: Unable to import... - triggers for external dependencies like numpy
+    E0401,
 
     # This was causing false positives
     # Appears to be https://github.com/PyCQA/pylint/issues/2981

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/AgentAction.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/agent_action.proto
+//     source: mlagents_envs/communicator_objects/agent_action.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/agent_action.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/agent_action.proto</summary>
   public static partial class AgentActionReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/agent_action.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/agent_action.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class AgentActionReflection {
     static AgentActionReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjVtbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2Fj",
+            "CjVtbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2Fj",
             "dGlvbi5wcm90bxIUY29tbXVuaWNhdG9yX29iamVjdHMiSwoQQWdlbnRBY3Rp",
             "b25Qcm90bxIWCg52ZWN0b3JfYWN0aW9ucxgBIAMoAhINCgV2YWx1ZRgEIAEo",
             "AkoECAIQA0oECAMQBEoECAUQBkIfqgIcTUxBZ2VudHMuQ29tbXVuaWNhdG9y",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/AgentInfo.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/agent_info.proto
+//     source: mlagents_envs/communicator_objects/agent_info.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/agent_info.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/agent_info.proto</summary>
   public static partial class AgentInfoReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/agent_info.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/agent_info.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,8 +24,8 @@ public static partial class AgentInfoReflection {
     static AgentInfoReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjNtbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2lu",
-            "Zm8ucHJvdG8SFGNvbW11bmljYXRvcl9vYmplY3RzGjRtbGFnZW50cy9lbnZz",
+            "CjNtbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2lu",
+            "Zm8ucHJvdG8SFGNvbW11bmljYXRvcl9vYmplY3RzGjRtbGFnZW50c19lbnZz",
             "L2NvbW11bmljYXRvcl9vYmplY3RzL29ic2VydmF0aW9uLnByb3RvItEBCg5B",
             "Z2VudEluZm9Qcm90bxIOCgZyZXdhcmQYByABKAISDAoEZG9uZRgIIAEoCBIY",
             "ChBtYXhfc3RlcF9yZWFjaGVkGAkgASgIEgoKAmlkGAogASgFEhMKC2FjdGlv",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/AgentInfoActionPair.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/agent_info_action_pair.proto
+//     source: mlagents_envs/communicator_objects/agent_info_action_pair.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/agent_info_action_pair.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/agent_info_action_pair.proto</summary>
   public static partial class AgentInfoActionPairReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/agent_info_action_pair.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/agent_info_action_pair.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,10 +24,10 @@ public static partial class AgentInfoActionPairReflection {
     static AgentInfoActionPairReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "Cj9tbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2lu",
+            "Cj9tbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2lu",
             "Zm9fYWN0aW9uX3BhaXIucHJvdG8SFGNvbW11bmljYXRvcl9vYmplY3RzGjNt",
-            "bGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2luZm8u",
-            "cHJvdG8aNW1sYWdlbnRzL2VudnMvY29tbXVuaWNhdG9yX29iamVjdHMvYWdl",
+            "bGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2FnZW50X2luZm8u",
+            "cHJvdG8aNW1sYWdlbnRzX2VudnMvY29tbXVuaWNhdG9yX29iamVjdHMvYWdl",
             "bnRfYWN0aW9uLnByb3RvIpEBChhBZ2VudEluZm9BY3Rpb25QYWlyUHJvdG8S",
             "OAoKYWdlbnRfaW5mbxgBIAEoCzIkLmNvbW11bmljYXRvcl9vYmplY3RzLkFn",
             "ZW50SW5mb1Byb3RvEjsKC2FjdGlvbl9pbmZvGAIgASgLMiYuY29tbXVuaWNh",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/BrainParameters.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/brain_parameters.proto
+//     source: mlagents_envs/communicator_objects/brain_parameters.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/brain_parameters.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/brain_parameters.proto</summary>
   public static partial class BrainParametersReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/brain_parameters.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/brain_parameters.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,9 +24,9 @@ public static partial class BrainParametersReflection {
     static BrainParametersReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjltbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2JyYWluX3Bh",
+            "CjltbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2JyYWluX3Bh",
             "cmFtZXRlcnMucHJvdG8SFGNvbW11bmljYXRvcl9vYmplY3RzGjNtbGFnZW50",
-            "cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL3NwYWNlX3R5cGUucHJvdG8i",
+            "c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL3NwYWNlX3R5cGUucHJvdG8i",
             "2QEKFEJyYWluUGFyYW1ldGVyc1Byb3RvEhoKEnZlY3Rvcl9hY3Rpb25fc2l6",
             "ZRgDIAMoBRIiChp2ZWN0b3JfYWN0aW9uX2Rlc2NyaXB0aW9ucxgFIAMoCRJG",
             "Chh2ZWN0b3JfYWN0aW9uX3NwYWNlX3R5cGUYBiABKA4yJC5jb21tdW5pY2F0",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/Command.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/command.proto
+//     source: mlagents_envs/communicator_objects/command.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/command.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/command.proto</summary>
   public static partial class CommandReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/command.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/command.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class CommandReflection {
     static CommandReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjBtbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2NvbW1hbmQu",
+            "CjBtbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2NvbW1hbmQu",
             "cHJvdG8SFGNvbW11bmljYXRvcl9vYmplY3RzKi0KDENvbW1hbmRQcm90bxII",
             "CgRTVEVQEAASCQoFUkVTRVQQARIICgRRVUlUEAJCH6oCHE1MQWdlbnRzLkNv",
             "bW11bmljYXRvck9iamVjdHNiBnByb3RvMw=="));

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/CustomResetParameters.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/custom_reset_parameters.proto
+//     source: mlagents_envs/communicator_objects/custom_reset_parameters.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/custom_reset_parameters.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/custom_reset_parameters.proto</summary>
   public static partial class CustomResetParametersReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/custom_reset_parameters.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/custom_reset_parameters.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class CustomResetParametersReflection {
     static CustomResetParametersReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CkBtbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2N1c3RvbV9y",
+            "CkBtbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2N1c3RvbV9y",
             "ZXNldF9wYXJhbWV0ZXJzLnByb3RvEhRjb21tdW5pY2F0b3Jfb2JqZWN0cyIc",
             "ChpDdXN0b21SZXNldFBhcmFtZXRlcnNQcm90b0IfqgIcTUxBZ2VudHMuQ29t",
             "bXVuaWNhdG9yT2JqZWN0c2IGcHJvdG8z"));

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/DemonstrationMeta.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/demonstration_meta.proto
+//     source: mlagents_envs/communicator_objects/demonstration_meta.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/demonstration_meta.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/demonstration_meta.proto</summary>
   public static partial class DemonstrationMetaReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/demonstration_meta.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/demonstration_meta.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class DemonstrationMetaReflection {
     static DemonstrationMetaReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjttbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2RlbW9uc3Ry",
+            "CjttbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2RlbW9uc3Ry",
             "YXRpb25fbWV0YS5wcm90bxIUY29tbXVuaWNhdG9yX29iamVjdHMijQEKFkRl",
             "bW9uc3RyYXRpb25NZXRhUHJvdG8SEwoLYXBpX3ZlcnNpb24YASABKAUSGgoS",
             "ZGVtb25zdHJhdGlvbl9uYW1lGAIgASgJEhQKDG51bWJlcl9zdGVwcxgDIAEo",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/EngineConfiguration.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/engine_configuration.proto
+//     source: mlagents_envs/communicator_objects/engine_configuration.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/engine_configuration.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/engine_configuration.proto</summary>
   public static partial class EngineConfigurationReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/engine_configuration.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/engine_configuration.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class EngineConfigurationReflection {
     static EngineConfigurationReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "Cj1tbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2VuZ2luZV9j",
+            "Cj1tbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2VuZ2luZV9j",
             "b25maWd1cmF0aW9uLnByb3RvEhRjb21tdW5pY2F0b3Jfb2JqZWN0cyKVAQoY",
             "RW5naW5lQ29uZmlndXJhdGlvblByb3RvEg0KBXdpZHRoGAEgASgFEg4KBmhl",
             "aWdodBgCIAEoBRIVCg1xdWFsaXR5X2xldmVsGAMgASgFEhIKCnRpbWVfc2Nh",

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/Header.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/header.proto
+//     source: mlagents_envs/communicator_objects/header.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/header.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/header.proto</summary>
   public static partial class HeaderReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/header.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/header.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class HeaderReflection {
     static HeaderReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "Ci9tbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2hlYWRlci5w",
+            "Ci9tbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL2hlYWRlci5w",
             "cm90bxIUY29tbXVuaWNhdG9yX29iamVjdHMiLgoLSGVhZGVyUHJvdG8SDgoG",
             "c3RhdHVzGAEgASgFEg8KB21lc3NhZ2UYAiABKAlCH6oCHE1MQWdlbnRzLkNv",
             "bW11bmljYXRvck9iamVjdHNiBnByb3RvMw=="));

UnitySDK/Assets/ML-Agents/Scripts/Grpc/CommunicatorObjects/Observation.cs

@@ -1,6 +1,6 @@
 // <auto-generated>
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
-//     source: mlagents/envs/communicator_objects/observation.proto
+//     source: mlagents_envs/communicator_objects/observation.proto
 // </auto-generated>
 #pragma warning disable 1591, 0612, 3021
 #region Designer generated code
@@ -11,11 +11,11 @@
 using scg = global::System.Collections.Generic;
 namespace MLAgents.CommunicatorObjects {
 
-  /// <summary>Holder for reflection information generated from mlagents/envs/communicator_objects/observation.proto</summary>
+  /// <summary>Holder for reflection information generated from mlagents_envs/communicator_objects/observation.proto</summary>
   public static partial class ObservationReflection {
 
     #region Descriptor
-    /// <summary>File descriptor for mlagents/envs/communicator_objects/observation.proto</summary>
+    /// <summary>File descriptor for mlagents_envs/communicator_objects/observation.proto</summary>
     public static pbr::FileDescriptor Descriptor {
       get { return descriptor; }
     }
@@ -24,7 +24,7 @@ public static partial class ObservationReflection {
     static ObservationReflection() {
       byte[] descriptorData = global::System.Convert.FromBase64String(
           string.Concat(
-            "CjRtbGFnZW50cy9lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL29ic2VydmF0",
+            "CjRtbGFnZW50c19lbnZzL2NvbW11bmljYXRvcl9vYmplY3RzL29ic2VydmF0",
             "aW9uLnByb3RvEhRjb21tdW5pY2F0b3Jfb2JqZWN0cyL5AQoQT2JzZXJ2YXRp",
             "b25Qcm90bxINCgVzaGFwZRgBIAMoBRJEChBjb21wcmVzc2lvbl90eXBlGAIg",
             "ASgOMiouY29tbXVuaWNhdG9yX29iamVjdHMuQ29tcHJlc3Npb25UeXBlUHJv",