Move mlagents.envs #2902
Closed
Move mlagents.envs #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2019 11:09
|
What about I'm also beginning to think the right thing may be to just re-combine the two packages. Have you thought about that option? |
|
I think removing the |
|
does the windows protobuf generation script also need to be updated? |
|
Cool, will probably redo this PR instead of fixing the merge conflicts. I'll make sure to update the windows script, although it's probably less important now that we removed the Custom* protos. |
|
Closing this for now, will revisit soon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename mlagents.envs to mlagentsenvs.envs.
The old naming scheme relied on PEP420 which was causing problems with pylint (had to disable a warning) and mypy (couldn't enable --namespace-packages without hitting python/mypy#7510, but this missed some errors).
Open to suggestions on the name. We could remove the
envsdirectory so the imports are e.g.mlagentsenvs.environmentinstead ofmlagents.envs.environmentCurrently this just moves the files and updates the imports and the proto files. I'll do another pass to fix any doc changes if we're OK with the move and the name. Expecting mypy to fail until the newly uncovered errors are fixed.