test: connection approval and invalid NetworkPrefabs within NetworkConfig.NetworkPrefabs #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just removing the exception within the try catch as it isn't needed for this test.
| public void Setup() | ||
| { | ||
| // Create, instantiate, and host | ||
| Assert.IsTrue(NetworkManagerHelper.StartNetworkManager(out _,NetworkManagerHelper.NetworkManagerOperatingMode.None)); |
There was a problem hiding this comment.
@NoelStephensUnity @TwoTenPvP I like these helpers to simplify unit tests, but I think we may now have 2 sets of helpers. Is this right? Can we merge them into one?
There was a problem hiding this comment.
That is a good idea.
| m_IsValidated = false; | ||
| NetworkManagerHelper.NetworkManagerObject.StartHost(); | ||
|
|
||
| var timeOut = Time.realtimeSinceStartup + 3.0f; |
There was a problem hiding this comment.
I assume these 3.0 & 0.01 time values have a rationale to them and are compatible with how things operate on Yamato?
There was a problem hiding this comment.
Yep... it was a "wild guess" of what to realistically expect Yamato's read/write times when under a heavy load (worst case scenario)...so far it seems to be working out ok... :)
mattwalsh-unity
approved these changes
May 11, 2021
NoelStephensUnity
deleted the
test/ConnectionAproval_and_InvalidNetworkPrefabsDuringInit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a connection approval handler non-multi-NetworkManager unit test.
Added a regression test for PR-818.