fix: NetworkManager doesn't destroy itself on multi instance #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can now be overriden BREAKING CHANGE: Static lifecycle properties in NetworkBehaviour are no longer static
| @@ -721,14 +721,6 @@ private void Awake() | |||
|
|
|||
| private void OnEnable() | |||
| { | |||
| if (Singleton != null && Singleton != this) | |||
| { | |||
| Destroy(gameObject); | |||
There was a problem hiding this comment.
I'm not super familiar with what this code does, but when I read the PR title I anticipated to see "if multi-scene, don't destroy, else still do" but what I see here is we don't destroy the game object anymore
There was a problem hiding this comment.
Yeah, it makes no sense for us to destroy it. I can't remember why I did it that way.
Basically what this used to do was:
If there was a NetworkManager already, destroy myself.
Now it doesn't destroy it anymore. That's the only difference.
mattwalsh-unity
approved these changes
Apr 24, 2021
0xFA11
reviewed
Apr 26, 2021
0xFA11
reviewed
Apr 26, 2021
0xFA11
suggested changes
Apr 26, 2021
NoelStephensUnity
approved these changes
Apr 26, 2021
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
0xFA11
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.