Skip to content

refactor: BufferManager is no longer static #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2021
Merged

refactor: BufferManager is no longer static #705

merged 2 commits into from
Apr 6, 2021

Conversation

TwoTenPvP
Copy link
Contributor

No description provided.

@TwoTenPvP TwoTenPvP marked this pull request as draft April 6, 2021 09:03
@TwoTenPvP TwoTenPvP marked this pull request as ready for review April 6, 2021 09:09
NoelStephensUnity
NoelStephensUnity reviewed Apr 6, 2021
View reviewed changes
NoelStephensUnity
NoelStephensUnity approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TwoTenPvP TwoTenPvP merged commit e51d7e7 into develop Apr 6, 2021
@TwoTenPvP TwoTenPvP deleted the singleton-removal-buffer-manager branch April 6, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoTenPvP @NoelStephensUnity