Skip to content

refactor: make editor serialized paths strongly typed #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

TwoTenPvP
Copy link
Contributor

No description provided.

@TwoTenPvP TwoTenPvP changed the base branch from master to develop March 12, 2021 12:06
Copy link
Contributor

@LukeStampfli LukeStampfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, we should always use nameof where possible.

Not for this PR but for the future, do we really want this NetworkManagerEditor with its complicated property overrides or should we just use default editor and expose NetworkConfig. We can use a custom inspector to get rid of the dropdown to get a similar result but this would probably reduce confusion on how to access these properties by code.

@TwoTenPvP TwoTenPvP changed the title refactor: Editor referece strong names refactor: Made editor serialized paths strongly typed Mar 12, 2021
@TwoTenPvP
Copy link
Contributor Author

Beautiful, we should always use nameof where possible.

Not for this PR but for the future, do we really want this NetworkManagerEditor with its complicated property overrides or should we just use default editor and expose NetworkConfig. We can use a custom inspector to get rid of the dropdown to get a similar result but this would probably reduce confusion on how to access these properties by code.

The main reason it's there is to disable parts of the inspector when certain options are chosen. And primarily to allow for the prefabs list and scene lists to be reordered. My personal opinion is yes, it should be kept.

@TwoTenPvP TwoTenPvP enabled auto-merge (squash) March 12, 2021 12:14
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parking my fancy 🚀 here — woot woot!

@0xFA11 0xFA11 changed the title refactor: Made editor serialized paths strongly typed refactor: make editor serialized paths strongly typed Mar 12, 2021
@TwoTenPvP TwoTenPvP merged commit c81cf51 into develop Mar 12, 2021
@TwoTenPvP TwoTenPvP deleted the refactor/editor-strong-names branch March 12, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants