Skip to content

fix: Nested NetworkTransform synchronization fails when parent has non-Vector3.one scale [MTT-6304] #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 18, 2023
Merged

fix: Nested NetworkTransform synchronization fails when parent has non-Vector3.one scale [MTT-6304] #2538

merged 13 commits into from
May 18, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 28, 2023 •
edited
Loading

This resolves the issue where parenting a NetworkTransform under a transform with a scale other than Vector3.one would result in incorrect values on non-authoritative instances.
MTT-6304
fix: #2516
fix: #2549

Changelog

  • Fixed: issue where parenting a NetworkTransform under a transform with a scale other than Vector3.one would result in incorrect values on non-authoritative instances.

Testing and Documentation

  • Includes integration test updates.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
70da1ea 
This fixes an issue with interpolation causing nonauthoritative NetworkTransform instances to not properly reflect the final axis values when parenting changes.
@NoelStephensUnity
Merge branch 'develop' into fix/networktransform-scale-synchronization
7a7ad8d
@NoelStephensUnity
test
c069ea0 
Updating the parenting test to validate the fix for parenting a nested NetworkTransform and assuring that values are the same.
@NoelStephensUnity
fix
b41162f 
Handle the condition that no new states have been pushed for a late joining client.
(i.e. it just synchronized a nested NetworkTransform and that is it)
@NoelStephensUnity
test
0c476f6 
Did an overhaul on the parented NetworkTransformTest (formerly NetworkTransformParentedLocalSpaceTest), renamed it to ParentedNetworkTransformTest, and now it tests both world and local space values depending upon how the NetworkObject is parented.
@NoelStephensUnity
style
1b5c2d0 
removing commented out code.
@NoelStephensUnity
update
7209483 
Adding entry to changelog
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review April 28, 2023 23:36
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner April 28, 2023 23:36
@NoelStephensUnity NoelStephensUnity changed the title fix: Nested NetworkTransform synchronization fails when parent has non-Vector3.one scale fix: Nested NetworkTransform synchronization fails when parent has non-Vector3.one scale [MTT-6304] Apr 28, 2023
@NoelStephensUnity NoelStephensUnity mentioned this pull request May 4, 2023
Closed
@NoelStephensUnity NoelStephensUnity merged commit 2b92028 into develop May 18, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networktransform-scale-synchronization branch May 18, 2023 22:26
@NoelStephensUnity NoelStephensUnity mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlucas-unity samlucas-unity samlucas-unity approved these changes

@ShadauxCat ShadauxCat Awaiting requested review from ShadauxCat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkTransform.useHalfFloatPercision causes initial sync to not work properly NetworkTransform local & world scaling.
2 participants
@NoelStephensUnity @samlucas-unity