Skip to content

chore: Hotfix - bump 1.0.2 and run tests #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2022
Merged

chore: Hotfix - bump 1.0.2 and run tests #2182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eaf2c4
Bump version to 1.0.2 and update changelog
ashwinimurt Sep 7, 2022
167fd78
Update changelog
ashwinimurt Sep 8, 2022
a26bce4
fix
NoelStephensUnity Sep 7, 2022
08a8312
update
NoelStephensUnity Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com).

## [Unreleased]

### Fixed

- Implicit conversion of NetworkObjectReference to GameObject will now return null instead of throwing an exception if the referenced object could not be found (i.e., was already despawned) (#2158)
- Fixed warning resulting from a stray NetworkAnimator.meta file (#2153)
- Fixed ClientRpcs always reporting in the profiler view as going to all clients, even when limited to a subset of clients by `ClientRpcParams`. (#2144)
- Fixed RPC codegen failing to choose the correct extension methods for `FastBufferReader` and `FastBufferWriter` when the parameters were a generic type (i.e., List<int>) and extensions for multiple instantiations of that type have been defined (i.e., List<int> and List<string>) (#2142)
- Fixed throwing an exception in `OnNetworkUpdate` causing other `OnNetworkUpdate` calls to not be executed. (#1739)
Comment on lines -14 to -18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these being completely removed? are they duplicates or invalid?

Copy link
Contributor Author

@ashwinimurt ashwinimurt Sep 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special branch for the hotfix. It was branched from develop @ce1ab3ca9495caf3f906d8ca5459677614214837 and contains fixes for Network Transform only.
It does not contain the changes in the [Unreleased] section that are removed here.


## [1.0.2] - 2022-09-XX
## [1.0.2] - 2022-09-12

- Fixed issue where `NetworkTransform` was not honoring the InLocalSpace property on the authority side during OnNetworkSpawn. (#2170)
- Fixed issue where `NetworkTransform` was not ending extrapolation for the previous state causing non-authoritative instances to become out of synch. (#2170)
- Fixed issue where `NetworkTransform` was not continuing to interpolate for the remainder of the associated tick period. (#2170)
- Fixed issue during `NetworkTransform.OnNetworkSpawn` for non-authoritative instances where it was initializing interpolators with the replicated network state which now only contains the transform deltas that occurred during a network tick and not the entire transform state. (#2170)
Expand Down
4 changes: 3 additions & 1 deletion com.unity.netcode.gameobjects/Components/NetworkTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,8 +1023,10 @@ public override void OnNetworkSpawn()
// that can be invoked when ownership changes.
if (CanCommitToTransform)
{
var currentPosition = InLocalSpace ? transform.localPosition : transform.position;
var currentRotation = InLocalSpace ? transform.localRotation : transform.rotation;
// Teleport to current position
SetStateInternal(transform.position, transform.rotation, transform.localScale, true);
SetStateInternal(currentPosition, currentRotation, transform.localScale, true);

// Force the state update to be sent
TryCommitTransform(transform, m_CachedNetworkManager.LocalTime.Time);
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "com.unity.netcode.gameobjects",
"displayName": "Netcode for GameObjects",
"description": "Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.",
"version": "1.0.1",
"version": "1.0.2",
"unity": "2020.3",
"dependencies": {
"com.unity.nuget.mono-cecil": "1.10.1",
Expand Down