chore: Hotfix - bump 1.0.2 and run tests #2182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinimurt
changed the title
NoelStephensUnity
approved these changes
Sep 7, 2022
0xFA11
reviewed
Sep 8, 2022
|
|
||
| - Changed version to 1.0.2. (#2170) |
There was a problem hiding this comment.
do we even need this entry here? (isn't the title tag obvious?)
0xFA11
reviewed
Sep 8, 2022
Comment on lines
-14
to
-18
| - Implicit conversion of NetworkObjectReference to GameObject will now return null instead of throwing an exception if the referenced object could not be found (i.e., was already despawned) (#2158) | ||
| - Fixed warning resulting from a stray NetworkAnimator.meta file (#2153) | ||
| - Fixed ClientRpcs always reporting in the profiler view as going to all clients, even when limited to a subset of clients by `ClientRpcParams`. (#2144) | ||
| - Fixed RPC codegen failing to choose the correct extension methods for `FastBufferReader` and `FastBufferWriter` when the parameters were a generic type (i.e., List<int>) and extensions for multiple instantiations of that type have been defined (i.e., List<int> and List<string>) (#2142) | ||
| - Fixed throwing an exception in `OnNetworkUpdate` causing other `OnNetworkUpdate` calls to not be executed. (#1739) |
There was a problem hiding this comment.
why are these being completely removed? are they duplicates or invalid?
There was a problem hiding this comment.
This is a special branch for the hotfix. It was branched from develop @ce1ab3ca9495caf3f906d8ca5459677614214837 and contains fixes for Network Transform only.
It does not contain the changes in the [Unreleased] section that are removed here.
0xFA11
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix: Bump version to 1.0.2 and update changelog.
Pick additional fixes from #2170