fix: NetworkObject.NetworkHide destroys client-side in-scene placed NetworkObjects [MTT-4211] #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyrainy
approved these changes
Jul 28, 2022
lpmaurice
approved these changes
Jul 29, 2022
lpmaurice
deleted the
fix/MTT-4211-networkhide-destroys-clientside-inscene-networkobjects
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…etworkObjects [MTT-4211] (Unity-Technologies#2086) * fix MTT-4211 This fixes the issue where in-scene placed NetworkObjects were being destroyed when NetworkHide is invoked. * test MTT-4211 This adds an additional check for NetworkHide and NetworkShow towards the end of the in-scene placed NetworkObject synchronization test. * style whitespace fix * style Adjusting comments and adding additional API XML Documentation for readability and clarification purposes. * update MTT-4211 Updating the changelog. * update improving the logic used for readability purposes since we know IsSceneObject will be valid. * style migrating the majority of the comments into remarks. * style Adding space within all added <br/> tags so they look like this: <br /> This is to see if the version of docusaurus we are using will not crash when it runs across this markdown syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where NetworkHide was still destroying in-scene placed NetworkObjects on the client side which would cause the client to throw a soft synchronization error when NetworkShow was called on the same NetworkObject (server-side) for the same client it was hidden from. Now, in-scene placed NetworkObjects are only despawned when NetworkHide is invoked.
MTT-4211
This resolves issue #1953
Changelog
NetworkObject.NetworkHidewas despawning and destroying, as opposed to only despawning, in-scene placedNetworkObjects.Testing and Documentation