fix: NetworkSceneManager notifications for scene not in build settings [MTT-2941] #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an editor side only fix to determine if the currently opened and active scene in the editor is not in the build list and if a NetworkManager instance exists that has scene management enabled. If so, then it will display a dialog box informing the user that the scene should be added to the scenes in build list as well as provide the user the option to have it done for them.
…e-not-in-build-settings
…e-not-in-build-settings
…e-not-in-build-settings
MTT-2941 Final changelog modification for better user notification clarity.
0xFA11
changed the title
Rosme
approved these changes
Mar 24, 2022
NoelStephensUnity
deleted the
fix/networkscenemanager-notification-scene-not-in-build-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves an exception message's clarity when a scene is not included in the build list only on the client side. This only happens when running under unique scenarios (i.e. using virtual projects) where a client could be launched from an editor instance and not have the scene available when building the scene hash table.
This PR also includes a check when entering into play mode from within the editor to determine if the scene needs to be added to the scenes in build list and if so displays a dialog box to the user providing the user with the option of having it added at that time prior to entering into play mode.
MTT-2941
Changelog
com.unity.netcode.gameobjects
Additional Information
The dialog box message looks like this:
