refactor: remove animation, physics and physics2d dependencies #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
commented
Mar 17, 2022
Comment on lines
-8
to
-10
| "com.unity.modules.animation": "1.0.0", | ||
| "com.unity.modules.physics": "1.0.0", | ||
| "com.unity.modules.physics2d": "1.0.0", |
There was a problem hiding this comment.
this feels so good, isn't it? :)
ashwinimurt
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.unity.modules.animation,com.unity.modules.physicsandcom.unity.modules.physics2dhard dependencies from the SDK#if <macro>guardingNetworkAnimator,NetworkRigidbody,NetworkRigidbody2Dand related tests and editor codetestprojecthas all these 3 packages in itsmanifest.jsonfile and is runningNetworkAnimatorTests,NetworkRigidbodyTestsandNetworkRigidbody2DTestsminimalprojectdoesn't have any of these 3 packages and validating the absence of these packages not causing any dependency issuesunity-configCLI to progressively add/remove packages duringtestprojecttests (run testproject & sdk tests with and without these packages) — but that'll be addressed laterFYI @JesseOlmer @lpmaurice @mattwalsh-unity
MTT-2702