fix: inscene networkobjects get destroyed upon client networkmanager shutting down without connecting #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered that I needed to create a bit more of a unique test for this fix. Reverting all changes to NetworkManagerTests and created new SceneObjectsNotDestroyedOnShutdownTest.
…-destroyed-upon-networkmanager-shuttingdown-without-connecting
…-destroyed-upon-networkmanager-shuttingdown-without-connecting
…-destroyed-upon-networkmanager-shuttingdown-without-connecting
0xFA11
force-pushed
the
fix/nccbug-119-inscene-networkobjects-get-destroyed-upon-networkmanager-shuttingdown-without-connecting
branch
from
a5b759a to
65d47a2
Compare
0xFA11
approved these changes
Mar 18, 2022
…d-upon-networkmanager-shuttingdown-without-connecting
0xFA11
deleted the
fix/nccbug-119-inscene-networkobjects-get-destroyed-upon-networkmanager-shuttingdown-without-connecting
branch
| @@ -740,7 +740,7 @@ internal void DespawnAndDestroyNetworkObjects() | |||
|
|
|||
| OnDespawnObject(networkObjects[i], shouldDestroy); | |||
| } | |||
| else | |||
| else if (networkObjects[i].IsSceneObject != null && !networkObjects[i].IsSceneObject.Value) | |||
There was a problem hiding this comment.
Worth a comment for clarity of
"IsSceneObject will be null if I've never connected, or will be true (and stay true) if I've connected and am (and always will be) a scene object."
|
Hi, I've encountered the same issue using NGO 1.8.1 with a nearly blank project. I notice that there was a change related to this section 6 months ago in commit 7ab9947. Could you please check it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any NetworkObjects living in a scene (or even DDOL) will get destroyed if during a client connection attempt, it fails or it gets cancelled.
NCCBUG-119
Changelog
com.unity.netcode.gameobjects
Testing and Documentation