In-Scene NetworkObjects get destroyed if NetworkManager shuts down while not fully connected (e.g. failed connection attempt)

[WhippetsAintDogs]

Describe the bug
Any NetworkObjects living in a scene (or even DDOL) will get destroyed if during connection attempt, it fails or it gets cancelled.

To Reproduce
Steps to reproduce the behavior:

1. Add a GameObject with a NetworkObject (Don't Destroy With Owner = true) component to a scene.
2. Setup a NetworkManager with UNet's transport.
3. Start the scene in Play Mode.
4. Start the NetworkManager as client, but don't let it connect to a server.
5. Shut down the NetworkManager.

Actual outcome
The GameObject holding the NetworkObject is destroyed.

Expected outcome
The GameObject holding the NetworkObject should only be despawned and it should eventually be destroyed when the scene is unloaded, not before.

Environment (please complete the following information):

• OS: Windows 10
• Unity Version: 2020.3
• Netcode Version: 1.0.0-pre.5

Additional context
During the connection attempt, the NetworkManager is in the following state: IsClient = true, IsConnectedClient = false. Every NetworkObjects are not yet spawned (IsSpawned = false).

Then, a NetworkManager Shutdown is done (because the connection attempt is cancelled or timed out).

NetworkManager's ShutdownInternal method is invoked, which then invokes NetworkSpawnManager's DespawnAndDestroyNetworkObjects method which - since those in-scene NetworkObjects aren't spawned yet - fall into its else case which Object.Destroy them.

[will-mearns]

@NoelStephensUnity , can you just transfer this over to Jira for now for us to triage?

[WhippetsAintDogs]

@will-mearns I've sent a reproduction project when I've filed this through Unity's bug reporting tool if you need it.

[will-mearns]

Perfect, that will help us reproduce the issue. In the future, you don't have to submit a Github issue here as well.

[ashwinimurt]

Linking bug for tracking https://fogbugz.unity3d.com/f/cases/1401687/

[ashwinimurt]

@NoelStephensUnity The bug is moved here https://jira.unity3d.com/browse/NCCBUG-119

[WhippetsAintDogs]

@will-mearns @ashwinimurt, just wondering about the visibility of Unity's bug reporting process. Its been more than a week that've filed the bug and it's still not visible in https://issuetracker.unity3d.com/ (and I don't know when it will be). Someone encountering the same problem I had could need this information. I understand the importance of this process to you guys and the bug reporting tool seems like the right tool for it. But, as a compromise, we could file both and even auto-close the issue in GitHub - so it won't clutter the other feedback / feature requests while still being searchable.

[ezoray]

@WhippetsAintDogs Agreed, the positive of using the bug reporter means an easy way of attaching a project to go along with the report. The negative from a user perspective is we have no visibility if it's even been acknowledged and this seems a step backward from adding issues directly in Github. I did post about this on the forum but no response so far.

[ashwinimurt]

@WhippetsAintDogs There seems to be an internal problem that prevented creating the Issue tracker for this particular bug. I have requested the customer QA teams to fix and have it created. I understand that not being able to easily search for an issue is a concern. We will discuss with the team. Thank you for the feedback.

[WhippetsAintDogs]

#1809

[WhippetsAintDogs]

Fixed in pre.7