Skip to content

fix: spawn flow to propagate IsSceneObject down to children NetworkObjects, decouple implicit relationship between object spawning & IsSceneObject flag #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 14, 2022
Merged

fix: spawn flow to propagate IsSceneObject down to children NetworkObjects, decouple implicit relationship between object spawning & IsSceneObject flag #1685

merged 8 commits into from
Feb 14, 2022

Conversation

jeffreyrainy
Copy link
Contributor

@jeffreyrainy jeffreyrainy commented Feb 11, 2022 •
edited by 0xFA11
Loading

Fixes #1523
Tracked by MTT-2074

This PR allows player prefabs to have nested NetworkObjects

Testing and Documentation

  • TestProject now uses a nested player prefab that demonstrate the functionality

@jeffreyrainy
fix: MTT-2074 NetworkObject parenting per docs is not possible for a …
8a311b8 
…spawned player.

Also adding a NetworkObject parented under the Player Object in testproject to catch such issues earlier in the future
@jeffreyrainy
fix: separating the sweep of NetworkObject from the spawning. Since t…
88e98ab 
…he sweep depends on 'IsSceneObject' and 'SpawnNetworkObjectLocally' sets it (previous commit), this resulted in issues
@jeffreyrainy
style: netcode.standards
68dbcb4
@jeffreyrainy
Copy link
Contributor Author

adding @fernando-cortez as this is supposed to fix #1523

0xFA11
0xFA11 reviewed Feb 14, 2022
View reviewed changes
@0xFA11 0xFA11 changed the title fix: mtt-2074 NetworkObject parenting per docs is not possible for a spawned player. fix: find and spawn child NetworkObjects while spawning the parent NetworkObejct Feb 14, 2022
@0xFA11 0xFA11 changed the title fix: find and spawn child NetworkObjects while spawning the parent NetworkObejct fix: find and spawn child NetworkObjects while spawning the parent NetworkObject Feb 14, 2022
@0xFA11 0xFA11 changed the title fix: find and spawn child NetworkObjects while spawning the parent NetworkObject fix: propagate IsSceneObject down to children NetworkObjects to cause them spawn over the network Feb 14, 2022
@0xFA11 0xFA11 changed the title fix: propagate IsSceneObject down to children NetworkObjects to cause them spawn over the network fix: propagate IsSceneObject down to children NetworkObjects Feb 14, 2022
@0xFA11 0xFA11 changed the title fix: propagate IsSceneObject down to children NetworkObjects fix: propagate IsSceneObject down to children NetworkObjects, decouple implicit relationship between object spawning & IsSceneObject flag Feb 14, 2022
0xFA11
0xFA11 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md and it's good to go!

@0xFA11 0xFA11 changed the title fix: propagate IsSceneObject down to children NetworkObjects, decouple implicit relationship between object spawning & IsSceneObject flag fix: spawn flow to propagate IsSceneObject down to children NetworkObjects, decouple implicit relationship between object spawning & IsSceneObject flag Feb 14, 2022
@0xFA11 0xFA11 enabled auto-merge (squash) February 14, 2022 22:03
@0xFA11 0xFA11 disabled auto-merge February 14, 2022 22:03
@0xFA11 0xFA11 enabled auto-merge (squash) February 14, 2022 22:03
@jeffreyrainy
Copy link
Contributor Author

Please add an entry to CHANGELOG.md and it's good to go!

Thanks! I see you just did it. 👍

@0xFA11 0xFA11 merged commit 732a77f into develop Feb 14, 2022
@0xFA11 0xFA11 deleted the fix/MTT-2074 branch February 14, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@NoelStephensUnity NoelStephensUnity Awaiting requested review from NoelStephensUnity

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkObject parenting per docs is not possible for a spawned player.
2 participants
@jeffreyrainy @0xFA11