Skip to content

fix: Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled. #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ShadauxCat
Copy link
Collaborator

MTT-1560
fixes #1306

Changelog

com.unity.netcode.gameobjects

  • Fixed: Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled.

Testing and Documentation

  • Includes integration tests.
  • No documentation changes or additions were necessary.

ShadauxCat and others added 2 commits February 10, 2022 20:22
…for connecting clients when Scene Management is enabled.

# Conflicts:
#	com.unity.netcode.gameobjects/Tests/Runtime/NetworkVisibilityTests.cs
@@ -6,6 +6,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

Additional documentation and release notes are available at [Multiplayer Documentation](https://docs-multiplayer.unity3d.com).

== [Unreleased]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all of these additions should match the same format as 1.0.0-pre.5 and below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... TIL the font I'm using makes # look like =.

Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question of the change in format (maybe === is the same as ###), the rest looks good to me.

@ShadauxCat
Copy link
Collaborator Author

This one will actually have to wait until 0b40c44 is backported into develop, as it depends on code from that commit.

@0xFA11
Copy link
Contributor

0xFA11 commented Feb 17, 2022

#1509 for tracking

@0xFA11 0xFA11 enabled auto-merge (squash) February 18, 2022 02:00
@0xFA11 0xFA11 merged commit 8334e94 into develop Feb 18, 2022
@0xFA11 0xFA11 deleted the fix/CheckObjectVisibility_for_connecting_clients_develop branch February 18, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkObject CheckObjectVisibility delegate not invoked for connecting clients
3 participants