fix: Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled (#1680)

Co-authored-by: Fatih Mar <mfatihmar@gmail.com>

Author: ShadauxCat

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -23,6 +23,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Fixed overloading RPC methods causing collisions and failing on IL2CPP targets. (#1694)
 - Fixed spawn flow to propagate `IsSceneObject` down to children NetworkObjects, decouple implicit relationship between object spawning & `IsSceneObject` flag (#1685)
 - Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1720)
+- Fixed CheckObjectVisibility delegate not being properly invoked for connecting clients when Scene Management is enabled. (#1680)
 
 ## [1.0.0-pre.5] - 2022-01-26
 

com.unity.netcode.gameobjects/Runtime/SceneManagement/SceneEventData.cs

@@ -233,7 +233,14 @@ internal void InitializeForSynch()
 
         internal void AddSpawnedNetworkObjects()
         {
-            m_NetworkObjectsSync = m_NetworkManager.SpawnManager.SpawnedObjectsList.ToList();
+            m_NetworkObjectsSync.Clear();
+            foreach (var sobj in m_NetworkManager.SpawnManager.SpawnedObjectsList)
+            {
+                if (sobj.Observers.Contains(TargetClientId))
+                {
+                    m_NetworkObjectsSync.Add(sobj);
+                }
+            }
             m_NetworkObjectsSync.Sort(SortNetworkObjects);
         }
 

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -835,7 +835,7 @@ internal void UpdateObservedNetworkObjects(ulong clientId)
         {
             foreach (var sobj in SpawnedObjectsList)
             {
-                if (sobj.CheckObjectVisibility == null || NetworkManager.IsServer)
+                if (sobj.CheckObjectVisibility == null)
                 {
                     if (!sobj.Observers.Contains(clientId))
                     {

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVisibilityTests.cs

@@ -22,7 +22,7 @@ public void TearDown()
         }
 
         [UnityTest]
-        public IEnumerator HiddenObjectsTest()
+        public IEnumerator HiddenObjectsTest([Values] bool enableSeneManagement)
         {
 
             const int numClients = 1;
@@ -37,11 +37,11 @@ public IEnumerator HiddenObjectsTest()
             var validNetworkPrefab = new NetworkPrefab();
             validNetworkPrefab.Prefab = m_TestNetworkPrefab;
             server.NetworkConfig.NetworkPrefabs.Add(validNetworkPrefab);
-            server.NetworkConfig.EnableSceneManagement = false;
+            server.NetworkConfig.EnableSceneManagement = enableSeneManagement;
             foreach (var client in clients)
             {
                 client.NetworkConfig.NetworkPrefabs.Add(validNetworkPrefab);
-                client.NetworkConfig.EnableSceneManagement = false;
+                client.NetworkConfig.EnableSceneManagement = enableSeneManagement;
             }
 
             // Start the instances