Skip to content

fix: Don't keep bad packets in the adapter's send queues (1.0.0) #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2022
Merged

fix: Don't keep bad packets in the adapter's send queues (1.0.0) #1659

merged 4 commits into from
Feb 10, 2022

Conversation

simon-lemay-unity
Copy link
Contributor

This is a backport of PR #1648 to release/1.0.0.

MTT-2408

Changelog

com.unity.netcode.adapter.utp

  • Fixed: Fixed an issue where packets causing errors would not be removed from the send queue, which would cause the error message to be spammed on every frame as the adapter would try to resend the packet.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity NoelStephensUnity merged commit 6489eac into release/1.0.0 Feb 10, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix-1.0.0/wrong-packets-in-queue branch February 10, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

@0xFA11 0xFA11 Awaiting requested review from 0xFA11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-lemay-unity @NoelStephensUnity